Update core to latest and configure components for the Client Authentication Extensions (2/2)#3694
Update core to latest and configure components for the Client Authentication Extensions (2/2)#3694tigrannajaryan merged 12 commits intoopen-telemetry:mainfrom gramidt:3692
Conversation
|
Looks like this needs a rebase |
@jpkrohling - Most definitely will need to be rebased, and core will need to be updated as the first commit in this PR once open-telemetry/opentelemetry-collector#3340 has been merged for it to compile. I expect I was able get the majority of the needed code in place (while not being able to compile), since my previous PRs focused on moving component clients (HTTP, gRPC) to Exporter.Start(...) were previously merged. |
gramidt
changed the title
|
@jpkrohling @tigrannajaryan @bogdandrutu @pavankrish123 - I can confirm after pointing the core collector module to my local core 3340 branch, |
|
@gramidt open-telemetry/opentelemetry-collector#3340 is merged, please go ahead with this PR. |
gramidt
requested review from
alolita,
anuraaga,
arminru,
djaglowski,
dmitryax,
jmacd,
jrcamp,
kbrockhoff,
mx-psi and
owais
as code owners
gramidt
changed the title
|
@tigrannajaryan @bogdandrutu @jpkrohling @pavankrish123 - Looks like we're ready. |
…ypes (#3694) With this change, we now infer the actual interval startTime for cumulative types from the original starttime interval reinforcing what the OpenTelemetry Proto recommendations say in https://github.com/open-telemetry/opentelemetry-proto/blob/bc8ee79d8e01faf3310af2987268e94285f354da/opentelemetry/proto/metrics/v1/metrics.proto#L132-L140 Fixes #3691
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR #3674 Requires PR #3694 Updates #3691
5 participants
Description:
This is the second phase of #3507.
Link to tracking Issue:
#3692
Testing:
Unit tests
Documentation:
N/A
Notes
Component changes are based on open-telemetry/opentelemetry-collector#3340.
Also related to open-telemetry/opentelemetry-collector#3282