[receiver/k8sobjectsreceiver] k8sobject receiver support leader election#39054
Merged
dmitryax merged 10 commits intoopen-telemetry:mainfrom May 12, 2025
Merged
[receiver/k8sobjectsreceiver] k8sobject receiver support leader election#39054dmitryax merged 10 commits intoopen-telemetry:mainfrom
dmitryax merged 10 commits intoopen-telemetry:mainfrom
Conversation
Contributor
Author
4bb004b to
81d5190
Compare
81d5190 to
00284d7
Compare
atoulme
reviewed
Apr 5, 2025
atoulme
reviewed
Apr 5, 2025
atoulme
reviewed
Apr 5, 2025
atoulme
reviewed
Apr 5, 2025
atoulme
reviewed
Apr 5, 2025
atoulme
reviewed
Apr 5, 2025
Contributor
|
Please resolve conflicts and add tests. It would be ideal to have a unit test that covers an election with receivers joining and leaving. |
1bed805 to
c7a8865
Compare
Contributor
Author
|
@atoulme A normal unit test can‘t achieve your suggestion. I will try to add a new e2e test to address this. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
Hi @Frapschen have a look at this unit test may be it gives some inspiration: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/38429/files#diff-166c09ecb8e6d1da525f46005a9a3f6a8f5a4870b74f60a5e0e9a3adc7b97b60R96 ? |
Contributor
Author
c7a8865 to
a02815c
Compare
dmitryax
reviewed
May 7, 2025
Contributor
|
Moving to draft for now while you address comments, please mark ready for review once done. |
1ceb3a2 to
2bbd0e5
Compare
dmitryax
reviewed
May 8, 2025
8d2ba99 to
2461088
Compare
Co-authored-by: Antoine Toulme <antoine@toulme.name>
Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
8c62ff5 to
3867efa
Compare
dmitryax
approved these changes
May 12, 2025
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…ion (open-telemetry#39054) #### Description As open-telemetry#38426 move the k8sleaderelector from development to alpha, we can use it in k8sobjectsreceiver. --------- Co-authored-by: Antoine Toulme <antoine@toulme.name> Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…ion (open-telemetry#39054) #### Description As open-telemetry#38426 move the k8sleaderelector from development to alpha, we can use it in k8sobjectsreceiver. --------- Co-authored-by: Antoine Toulme <antoine@toulme.name> Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
As #38426 move the k8sleaderelector from development to alpha, we can use it in k8sobjectsreceiver.