[translator/azurelogs] Increase unit test coverage#39176
Merged
songy23 merged 5 commits intoopen-telemetry:mainfrom Apr 7, 2025
Merged
[translator/azurelogs] Increase unit test coverage#39176songy23 merged 5 commits intoopen-telemetry:mainfrom
songy23 merged 5 commits intoopen-telemetry:mainfrom
Conversation
MikeGoldsmith
approved these changes
Apr 5, 2025
Member
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks good to me. Just need to resolve the lint errors.
Contributor
Author
|
Thanks @MikeGoldsmith ! The lint errors are coming from |
Contributor
|
Please rebase off latest main. |
Contributor
Author
|
The branch is up to date with |
atoulme
approved these changes
Apr 7, 2025
atoulme
added
the
ready to merge
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Every test unit that was using a log file, now compares the full log structure with the expected one instead of just a few fields. The previous test units all passed. I have removed them as they are now redundant. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39136. --------- Co-authored-by: Antoine Toulme <atoulme@splunk.com>
atoulme
pushed a commit
that referenced
this pull request
Apr 17, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PRs adds myself (@constanca-m) to the codeowners of the component. Work done: - #39176 - #39200 Work in progress: - #39340 Work planned: - #39186 The company I work at (Elastic) is relying on this component in one of our products, so I plan to keep contributing to it. I hope that this change will: - Help and improve maintenance - Prevent breaking changes without warning - Help collaboration between codeowners from different companies.
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…elemetry#39457) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PRs adds myself (@constanca-m) to the codeowners of the component. Work done: - open-telemetry#39176 - open-telemetry#39200 Work in progress: - open-telemetry#39340 Work planned: - open-telemetry#39186 The company I work at (Elastic) is relying on this component in one of our products, so I plan to keep contributing to it. I hope that this change will: - Help and improve maintenance - Prevent breaking changes without warning - Help collaboration between codeowners from different companies.
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Every test unit that was using a log file, now compares the full log structure with the expected one instead of just a few fields. The previous test units all passed. I have removed them as they are now redundant. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39136. --------- Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…elemetry#39457) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PRs adds myself (@constanca-m) to the codeowners of the component. Work done: - open-telemetry#39176 - open-telemetry#39200 Work in progress: - open-telemetry#39340 Work planned: - open-telemetry#39186 The company I work at (Elastic) is relying on this component in one of our products, so I plan to keep contributing to it. I hope that this change will: - Help and improve maintenance - Prevent breaking changes without warning - Help collaboration between codeowners from different companies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every test unit that was using a log file, now compares the full log structure with the expected one instead of just a few fields.
The previous test units all passed. I have removed them as they are now redundant.
Link to tracking issue
Fixes #39136.