[pkg/ottl] Add GetOr function to ottl.Optional#40243
Merged
evan-bradley merged 6 commits intoopen-telemetry:mainfrom Jul 7, 2025
Merged
[pkg/ottl] Add GetOr function to ottl.Optional#40243evan-bradley merged 6 commits intoopen-telemetry:mainfrom
GetOr function to ottl.Optional#40243evan-bradley merged 6 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
Author
|
Hey @evan-bradley, could you please take a look at this when you get a chance? Thanks! |
evan-bradley
reviewed
Jul 6, 2025
Contributor
evan-bradley
left a comment
There was a problem hiding this comment.
Sorry it took me so long to get to this. This looks good to me, but I think we should add an API changelog entry.
GetOr function to ottl.OptionalGetOr function to ottl.Optional
evan-bradley
approved these changes
Jul 7, 2025
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main goal of this new function is to avoid repeating the following common pattern in functions with optional arguments:
This utility was discussed here, and would simplify the above code as:
Testing
Unit tests