Skip to content

fix(receiver/statsd): change metrics address from Local to Remote#41362

Merged
atoulme merged 28 commits intoopen-telemetry:mainfrom
clavinjune:fix/receiver-statsd
Jul 30, 2025
Merged

fix(receiver/statsd): change metrics address from Local to Remote#41362
atoulme merged 28 commits intoopen-telemetry:mainfrom
clavinjune:fix/receiver-statsd

Conversation

@clavinjune
Copy link
Contributor

Description

Changing the metrics that statsdreceiver need to record from LocalAddress to RemoteAddress

Link to tracking issue

Fixes #41361

@clavinjune clavinjune requested review from a team and dmitryax as code owners July 17, 2025 08:40
@github-actions github-actions bot added the receiver/statsd statsd related issues label Jul 17, 2025
@github-actions github-actions bot requested a review from jmacd July 17, 2025 08:40
@clavinjune
Copy link
Contributor Author

@MovieStoreGuy / @dmitryax / @jmacd could you please help review this? thank you 🙇

@atoulme
Copy link
Contributor

atoulme commented Jul 17, 2025

Please add a changelog withmake chlog-new

Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@clavinjune
Copy link
Contributor Author

Please add a changelog withmake chlog-new

done

@clavinjune
Copy link
Contributor Author

@dmitryax / @jmacd could you please help take a look on this one? Thanks in advance

Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a test to make sure it validates that it is getting the correct IP address.

@clavinjune
Copy link
Contributor Author

will do adding the tests

@clavinjune clavinjune requested a review from MovieStoreGuy July 30, 2025 06:36
@clavinjune
Copy link
Contributor Author

tests added please help to review @MovieStoreGuy @dmitryax @jmacd

@clavinjune
Copy link
Contributor Author

please help to merge if all's good @MovieStoreGuy

@atoulme
Copy link
Contributor

atoulme commented Jul 30, 2025

Please do not update your PR, or we can't run the build, and if we can't run the build, we can't merge it.

@atoulme atoulme merged commit 0455564 into open-telemetry:main Jul 30, 2025
178 checks passed
@clavinjune clavinjune deleted the fix/receiver-statsd branch July 31, 2025 00:09
Dylan-M pushed a commit to Dylan-M/opentelemetry-collector-contrib that referenced this pull request Aug 5, 2025
…en-telemetry#41362)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Changing the metrics that statsdreceiver need to record from
LocalAddress to RemoteAddress

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#41361

---------

Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[receiver/statsd] TCP Server sending Local Address and not Remote Address to the Metrics

4 participants