fix(receiver/statsd): change metrics address from Local to Remote#41362
Merged
atoulme merged 28 commits intoopen-telemetry:mainfrom Jul 30, 2025
Merged
fix(receiver/statsd): change metrics address from Local to Remote#41362atoulme merged 28 commits intoopen-telemetry:mainfrom
atoulme merged 28 commits intoopen-telemetry:mainfrom
Conversation
Contributor
Author
|
@MovieStoreGuy / @dmitryax / @jmacd could you please help review this? thank you 🙇 |
Contributor
|
Please add a changelog with |
Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
Contributor
Author
done |
Contributor
Author
Contributor
MovieStoreGuy
left a comment
There was a problem hiding this comment.
This should have a test to make sure it validates that it is getting the correct IP address.
Contributor
Author
|
will do adding the tests |
Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
Contributor
Author
|
tests added please help to review @MovieStoreGuy @dmitryax @jmacd |
MovieStoreGuy
approved these changes
Jul 30, 2025
Contributor
Author
|
please help to merge if all's good @MovieStoreGuy |
Contributor
|
Please do not update your PR, or we can't run the build, and if we can't run the build, we can't merge it. |
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…en-telemetry#41362) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Changing the metrics that statsdreceiver need to record from LocalAddress to RemoteAddress <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#41361 --------- Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changing the metrics that statsdreceiver need to record from LocalAddress to RemoteAddress
Link to tracking issue
Fixes #41361