Skip to content

feat(receiver/statsdreceiver): Introduce Explicit Bucket#41503

Merged
atoulme merged 69 commits intoopen-telemetry:mainfrom
clavinjune:feat/statsd-receiver-introduce-explicit-bucket
Sep 6, 2025
Merged

feat(receiver/statsdreceiver): Introduce Explicit Bucket#41503
atoulme merged 69 commits intoopen-telemetry:mainfrom
clavinjune:feat/statsd-receiver-introduce-explicit-bucket

Conversation

@clavinjune
Copy link
Contributor

@clavinjune clavinjune commented Jul 23, 2025 •
edited
Loading

Description

Introduce Explicit Bucket for Histogram configuration

      histogram:
        max_size: 170
        explicit_buckets:
          - matcher_pattern: "foo.*"
            buckets: [1, 10, 100]
          - matcher_pattern: "bar.*"
            buckets: [0.1, 0.5, 1]

If the metrics name matches one of the matcher pattern (sequential order), it will use the explicit bucket instead of exponential histogram

Link to tracking issue

Fixes #41203

Testing

Adding unit tests

Documentation

Added in the readme

@clavinjune
feat(receiver/statsd): introduce explicit bucket
13b732a 
Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@clavinjune clavinjune requested review from a team and dmitryax as code owners July 23, 2025 03:27
@github-actions github-actions bot added the receiver/statsd statsd related issues label Jul 23, 2025
@github-actions github-actions bot requested a review from jmacd July 23, 2025 03:27
@clavinjune clavinjune mentioned this pull request Jul 23, 2025
Closed
@clavinjune clavinjune changed the title feat(receiver/statsdreceiver): Introduce Explicit Bucket Draft: feat(receiver/statsdreceiver): Introduce Explicit Bucket Jul 23, 2025
@clavinjune clavinjune marked this pull request as draft July 23, 2025 03:28
clavinjune added 16 commits July 25, 2025 10:24
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
43967bc
@clavinjune
chore(receiver/statsdreceiver): run go mod tidy
cd8f7f9 
Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
99cef32
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
4f266d3
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
842b468
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
063c6b5
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
6c30f68
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
ee53c70
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
ac4fabd
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
7761398
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
27e1df0
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
49f5665
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
dbf5965
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
20aac21
@clavinjune
chore(receiver/statsd): add metric_translator_test for explicit bucket
22063e3 
Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@clavinjune
chore(receiver/statsd): add chlogen
5bde951 
Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@clavinjune clavinjune marked this pull request as ready for review August 2, 2025 15:17
@clavinjune clavinjune mentioned this pull request Aug 2, 2025
Closed
@clavinjune clavinjune changed the title Draft: feat(receiver/statsdreceiver): Introduce Explicit Bucket feat(receiver/statsdreceiver): Introduce Explicit Bucket Aug 2, 2025
@clavinjune
Copy link
Contributor Author

clavinjune commented Aug 2, 2025

@dmitryax @jmacd @mwear @edmocosta please help to review and approve 🙇

@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
a0ce9d8
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
9356255
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
c62b2e3
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
d64b954
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
9fe0ff5
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
bb4200d
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
f6ff0ff
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
56bccef
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
c1f81e2
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
3c56984
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
1b22134
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
85091b1
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
40a0d21
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
e27e621
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
3cc0813
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
3d14a99
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
0ce8369
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
2419269
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
818602d
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
18d7475
dmitryax
dmitryax approved these changes Aug 31, 2025
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just couple comment. Sorry for taking to loong to review

@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
35e4d8b
@clavinjune
chore(receiver/statsd): validate unsorted/duplicated explicit buckets
d6e8d8f 
Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@clavinjune
chore(receiver/statsd): remove sorting logic when initializing explic…
1c9dbb5 
…it buckets as it is duplicated with the config validation

Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@clavinjune
chore(receiver/statsd): split buildHistogramMetric function into expl…
361fb62 
…icit bucket and exponential bucket

Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@clavinjune
chore(receiver/statsd): run make generate
075037f 
Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
@clavinjune
Merge branch 'main' into feat/statsd-receiver-introduce-explicit-bucket
6a3041c
@atoulme atoulme merged commit 4ea1cb8 into open-telemetry:main Sep 6, 2025
184 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 6, 2025
@clavinjune clavinjune deleted the feat/statsd-receiver-introduce-explicit-bucket branch September 6, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitryax dmitryax dmitryax approved these changes

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

Assignees

@mwear mwear

@edmocosta edmocosta

Labels

receiver/statsd statsd related issues waiting-for-code-owners

Projects

None yet

Milestone

v0.135.0

Development

Successfully merging this pull request may close these issues.

[statsdreceiver] Support More Configuration Like Statsd Exporter

5 participants

@clavinjune @dmitryax @atoulme @mwear @edmocosta