[tailsamplingprocessor] Add BlockOnOverFlow option#41546
Merged
atoulme merged 5 commits intoopen-telemetry:mainfrom Aug 15, 2025
Merged
[tailsamplingprocessor] Add BlockOnOverFlow option#41546atoulme merged 5 commits intoopen-telemetry:mainfrom
atoulme merged 5 commits intoopen-telemetry:mainfrom
Conversation
When running the tailsampling processor as part of a durable collector pipeline, it's better to block trace intake than to drop old traces. This option makes it configurable to do so (default false).
This was referenced Jul 29, 2025
portertech
approved these changes
Aug 6, 2025
Contributor
Author
|
@atoulme Are you able to merge this? I see the waiting for code owners status, but we have @portertech's approval now 😄 |
atoulme
approved these changes
Aug 15, 2025
Contributor
atoulme
left a comment
atoulme
left a comment
There was a problem hiding this comment.
approved by codeowner, merging
This was referenced Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running the tailsampling processor as part of a durable collector pipeline, it's better to block trace intake than to drop old traces. This option makes it configurable to do so (default false).
Testing
Unit tests show the behavior of the new traceLimiter. I've also tested this change in our infrastructure at Grafana Labs and the pipeline backed up as expected until the decision timeout. This makes autoscaling of the TSP simpler to reason about, since we can confidently set an autoscaling target on in memory traces, and trust that during an ingestion spike we will slow down until the autoscaler can kick in.