[connector/signaltometrics]Drop collector service name and namespace from metrics#43150
Merged
songy23 merged 2 commits intoopen-telemetry:mainfrom Oct 7, 2025
Merged
[connector/signaltometrics]Drop collector service name and namespace from metrics#43150songy23 merged 2 commits intoopen-telemetry:mainfrom
songy23 merged 2 commits intoopen-telemetry:mainfrom
Conversation
graphaelli
reviewed
Oct 6, 2025
axw
approved these changes
Oct 7, 2025
Co-authored-by: Gil Raphaelli <graphaelli@gmail.com>
ChrsMark
approved these changes
Oct 7, 2025
ChrsMark
added
ready to merge
etserend
pushed a commit
to etserend/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2025
…from metrics (open-telemetry#43150) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description `signaltometrics.service.*` fields were added to the metrics produced from signaltometrics component to ensure single-writer is obeyed ([ref](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/connector/signaltometricsconnector#single-writer)). However, we don't require all the fields to ensure this. Based on the description of `service.instance.id` it is alone enough to ensure single-writer ([ref](https://opentelemetry.io/docs/specs/semconv/registry/attributes/service/)). The other fields leak information about the service which is not desirable and also unnecessary for our purpose. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#43148 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated in PR <!--Describe the documentation added.--> #### Documentation Updated <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Gil Raphaelli <graphaelli@gmail.com>
mashhurs
pushed a commit
to mashhurs/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2025
…from metrics (open-telemetry#43150) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description `signaltometrics.service.*` fields were added to the metrics produced from signaltometrics component to ensure single-writer is obeyed ([ref](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/connector/signaltometricsconnector#single-writer)). However, we don't require all the fields to ensure this. Based on the description of `service.instance.id` it is alone enough to ensure single-writer ([ref](https://opentelemetry.io/docs/specs/semconv/registry/attributes/service/)). The other fields leak information about the service which is not desirable and also unnecessary for our purpose. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#43148 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated in PR <!--Describe the documentation added.--> #### Documentation Updated <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Gil Raphaelli <graphaelli@gmail.com>
tommyers-elastic
pushed a commit
to tommyers-elastic/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2025
…from metrics (open-telemetry#43150) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description `signaltometrics.service.*` fields were added to the metrics produced from signaltometrics component to ensure single-writer is obeyed ([ref](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/connector/signaltometricsconnector#single-writer)). However, we don't require all the fields to ensure this. Based on the description of `service.instance.id` it is alone enough to ensure single-writer ([ref](https://opentelemetry.io/docs/specs/semconv/registry/attributes/service/)). The other fields leak information about the service which is not desirable and also unnecessary for our purpose. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#43148 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated in PR <!--Describe the documentation added.--> #### Documentation Updated <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Gil Raphaelli <graphaelli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
signaltometrics.service.*fields were added to the metrics produced from signaltometrics component to ensure single-writer is obeyed (ref). However, we don't require all the fields to ensure this. Based on the description ofservice.instance.idit is alone enough to ensure single-writer (ref). The other fields leak information about the service which is not desirable and also unnecessary for our purpose.Link to tracking issue
Fixes #43148
Testing
Updated in PR
Documentation
Updated