[exporter/awss3exporter] Added IsArchiveFormat for Sumo IC#43574
Merged
atoulme merged 9 commits intoopen-telemetry:mainfrom Oct 15, 2025
Merged
[exporter/awss3exporter] Added IsArchiveFormat for Sumo IC#43574atoulme merged 9 commits intoopen-telemetry:mainfrom
atoulme merged 9 commits intoopen-telemetry:mainfrom
Conversation
617ad78 to
5cde4ae
Compare
Contributor
Author
|
hey @atoulme, when you get a chance, could you take a look? thanks! |
atoulme
reviewed
Oct 15, 2025
atoulme
reviewed
Oct 15, 2025
38e0bdd to
99aed96
Compare
Contributor
Author
|
done! @atoulme |
atoulme
approved these changes
Oct 15, 2025
ChrsMark
pushed a commit
to ChrsMark/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2025
…metry#43574) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The sumo_ic marshaler was incorrectly blocked from using compression. Sumo Logic's Installed Collector compresses archive files before S3 upload, but the OpenTelemetry exporter prevented this, causing format incompatibility. Root cause: The exporter used ContentEncoding: "gzip" for all compressed uploads, which signals HTTP transfer compression (auto-decompressed by AWS). Archive formats like sumo_ic need files to stay compressed permanently. Solution: Added isArchiveFormat flag to distinguish between archive formats (files stay compressed) and transfer formats (HTTP optimization). The flag controls whether ContentEncoding header is set during upload. <!--Describe what testing was performed and which tests were added.--> #### Testing - Manual testing: Downloaded files from S3, verified gzip compression with file and gunzip commands - Unit test passed: ``` ➜ awss3exporter git:(sumoCompression) ✗ make test /Users/timothy.chan/Desktop/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 900s -parallel 4 --tags="" ∅ internal/metadata ✓ internal/upload (cached) ✓ . (2.662s) DONE 98 tests in 2.662s ``` <!--Describe the documentation added.--> #### Documentation - Removed outdated README that gzip doesn't support sumo_ic marshaler <!--Please delete paragraphs that you did not use before submitting.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sumo_ic marshaler was incorrectly blocked from using compression. Sumo Logic's Installed Collector compresses archive files before S3 upload, but the OpenTelemetry exporter prevented this, causing format incompatibility.
Root cause: The exporter used ContentEncoding: "gzip" for all compressed uploads, which signals HTTP transfer compression (auto-decompressed by AWS). Archive formats like sumo_ic need files to stay compressed permanently.
Solution: Added isArchiveFormat flag to distinguish between archive formats (files stay compressed) and transfer formats (HTTP optimization). The flag controls whether ContentEncoding header is set during upload.
Testing
Documentation