Skip to content

[processor/tailsampling] Disable invert decisions by default#44132

Merged
atoulme merged 4 commits intoopen-telemetry:mainfrom
csmarchbanks:disable-invert-decisions-by-default
Jan 8, 2026
Merged

[processor/tailsampling] Disable invert decisions by default#44132
atoulme merged 4 commits intoopen-telemetry:mainfrom
csmarchbanks:disable-invert-decisions-by-default

Conversation

@csmarchbanks
Copy link
Contributor

It would be nice to remove the logic around invert sampling decisions soon as it has now been 6 months since the values were deprecated. To begin doing so, set the feature gate to be enabled by default to force users to migrate to drop policies.

@csmarchbanks csmarchbanks force-pushed the disable-invert-decisions-by-default branch 4 times, most recently from 0b8c0d7 to e4f2218 Compare November 10, 2025 19:43
@csmarchbanks csmarchbanks marked this pull request as ready for review November 10, 2025 19:59
@csmarchbanks csmarchbanks requested a review from a team as a code owner November 10, 2025 19:59
@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Nov 10, 2025
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme
Copy link
Contributor

atoulme commented Dec 8, 2025

@Logiraptor @portertech please review as codeowners.

@atoulme atoulme requested a review from portertech December 8, 2025 23:29
It would be nice to remove the logic around invert sampling decisions
soon as it has now been 6 months since the values were deprecated. To
begin doing so, set the feature gate to be enabled by default to force
users to migrate to drop policies.
@csmarchbanks csmarchbanks force-pushed the disable-invert-decisions-by-default branch from e4f2218 to 0a7f57f Compare December 19, 2025 19:45
@csmarchbanks
Copy link
Contributor Author

I just fixed the conflicts with main and this has codeowner approval now so should be good to go!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 3, 2026
@csmarchbanks
Copy link
Contributor Author

Updated with main again, this is still ready to merge.

@github-actions github-actions bot removed the Stale label Jan 6, 2026
@atoulme atoulme merged commit eada647 into open-telemetry:main Jan 8, 2026
189 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 8, 2026
@otelbot
Copy link
Contributor

otelbot bot commented Jan 8, 2026

Thank you for your contribution @csmarchbanks! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

mbdeveci pushed a commit to mbdeveci/opentelemetry-collector-contrib that referenced this pull request Jan 12, 2026
…lemetry#44132)

It would be nice to remove the logic around invert sampling decisions
soon as it has now been 6 months since the values were deprecated. To
begin doing so, set the feature gate to be enabled by default to force
users to migrate to drop policies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants