[chore][pprofiles] Fix pprofile DurationNano to be a TypeUint64 by florianl · Pull Request #44397 · open-telemetry/opentelemetry-collector-contrib

florianl · 2025-11-19T15:48:49Z

Description

Complementary change to open-telemetry/opentelemetry-collector#14188.

Link to tracking issue

Fixes

Testing

Documentation

Complementary change to open-telemetry/opentelemetry-collector#14188. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

exporter/coralogixexporter/profiles_client_test.go

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

douglascamata

Thanks for taking the time to fix this!

pkg/ottl/contexts/internal/ctxprofile/profile.go

edmocosta · 2025-11-20T13:31:00Z

pkg/ottl/contexts/internal/ctxprofile/profile.go

 	return ottl.StandardGetSetter[K]{
 		Getter: func(_ context.Context, tCtx K) (any, error) {
-			return tCtx.GetProfile().Duration().AsTime(), nil
+			return tCtx.GetProfile().DurationNano(), nil


Suggested change

return tCtx.GetProfile().DurationNano(), nil

return time.Unix(0, int64(tCtx.GetProfile().DurationNano())).UTC(), nil

This should continue returning time.Time, like before.

I don't think this is a good idea. time.Time represents a point in time and not a duration. That is the whole point of open-telemetry/opentelemetry-collector#14188.

If Duration and its return time.Time should stay, what is the procedure to mark it as deprecated and direct people to use DurationNano?

My suggestion is to keep it returning time.Time for now (even if not ideal), so we don't need to delay this PR. We can handle this field deprecation and removal later in a separate breaking change issue.

Requiring multiple breaking changes sounds like a lot of overhead, not only for the collector-contrib side.
With 4dbce06 I have aligned the changes.

My suggestion was to not break it in this PR, the applied changes seems to be a breaking change, which isn't clear to users reading the added change log.

pkg/ottl/contexts/internal/ctxprofile/profile.go

#### Description pcommon.Timestamp better represents a point in time rather than a duration. So keeping the proto field type for DurationNano is a better fit. Corresponding Collector-contrib change: open-telemetry/opentelemetry-collector-contrib#44397 ping @open-telemetry/profiling-approvers  #### Link to tracking issue Fixes #  #### Testing  #### Documentation  --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

.chloggen/collector-14188.yaml

exporter/coralogixexporter/profiles_client_test.go

florianl · 2025-11-20T14:25:39Z

pkg/ottl/contexts/internal/ctxprofile/profile.go

 	return ottl.StandardGetSetter[K]{
 		Getter: func(_ context.Context, tCtx K) (any, error) {
-			return tCtx.GetProfile().Duration().AsTime(), nil
+			return tCtx.GetProfile().DurationNano(), nil


I don't think this is a good idea. time.Time represents a point in time and not a duration. That is the whole point of open-telemetry/opentelemetry-collector#14188.

florianl · 2025-11-21T07:36:58Z

pkg/ottl/contexts/internal/ctxprofile/profile.go

 	return ottl.StandardGetSetter[K]{
 		Getter: func(_ context.Context, tCtx K) (any, error) {
-			return tCtx.GetProfile().Duration().AsTime(), nil
+			return tCtx.GetProfile().DurationNano(), nil


If Duration and its return time.Time should stay, what is the procedure to mark it as deprecated and direct people to use DurationNano?

Co-authored-by: Vihas Makwana <121151420+VihasMakwana@users.noreply.github.com>

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

.chloggen/collector-14188.yaml

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>

mx-psi · 2025-11-24T17:37:45Z

I am going to merge this to avoid merge conflicts.

@TylerHelmuth @evan-bradley @edmocosta I believe Florian addressed the OTTL asks satisfactorily but PTAL as codeowners!

edmocosta · 2025-11-26T18:44:13Z

I am going to merge this to avoid merge conflicts.

@TylerHelmuth @evan-bradley @edmocosta I believe Florian addressed the OTTL asks satisfactorily but PTAL as codeowners!

The merged OTTL changes are a braking change (changed a field type), and unfortunately we don't have a specific change log for that, which is not ideal, even considering the profile stability. I wish we could split this kind of PRs per components in the future, at least when meaningful code is modified.

mx-psi · 2025-11-26T18:49:02Z

I am going to merge this to avoid merge conflicts.
@TylerHelmuth @evan-bradley @edmocosta I believe Florian addressed the OTTL asks satisfactorily but PTAL as codeowners!

The merged OTTL changes are a braking change (changed a field type), and unfortunately we don't have a specific change log for that, which is not ideal, even considering the profile stability.

Wouldn't an API changelog work for that?

I wish we could split this kind of PRs per components in the future, at least when meaningful code is modified.

I am supportive of this, feel free to block the PR in the future if you'd rather the PR not be merged

edmocosta · 2025-11-26T19:21:25Z

Wouldn't an API changelog work for that?

That's an user breaking change, the previous duration field type was time.Time, and it was changed to int64. Usages of that field on OTTL statement can possibly break the collector config validation.

I'm on PTO and will only have access to my computer next week, if someone else could apply this suggestion or add the change log, that would be great. @TylerHelmuth @evan-bradley @florianl?

Thank you!

mx-psi · 2025-11-26T20:17:52Z

I misunderstood your point, sorry. I created a release blocker issue based on your comment to add the entry, see #44560

[chore][pprofiles] Fix pprofile DurationNano to be a TypeUint64

59b8c06

Complementary change to open-telemetry/opentelemetry-collector#14188. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

florianl requested review from a team, TylerHelmuth, VihasMakwana, edmocosta, evan-bradley and fatsheep9146 as code owners November 19, 2025 15:48

github-actions bot assigned mwear Nov 19, 2025

github-actions bot added pkg/translator/pprof pkg/pdatatest pkg/ottl extension/encoding/otlpencoding exporter/file exporter/coralogix labels Nov 19, 2025

github-actions bot requested review from atingchen, dao-jun, douglascamata, iblancasa and povilasv November 19, 2025 15:49

florianl mentioned this pull request Nov 19, 2025

Fix pprofile DurationNano to be a TypeUint64 open-telemetry/opentelemetry-collector#14188

Merged

douglascamata suggested changes Nov 19, 2025

View reviewed changes

exporter/coralogixexporter/profiles_client_test.go Outdated Show resolved Hide resolved

use SetDurationNano(uint64(1 * time.Second.Nanoseconds()))

64c21ea

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

douglascamata approved these changes Nov 20, 2025

View reviewed changes

edmocosta reviewed Nov 20, 2025

View reviewed changes

VihasMakwana reviewed Nov 21, 2025

View reviewed changes

.chloggen/collector-14188.yaml Outdated Show resolved Hide resolved

florianl commented Nov 21, 2025

View reviewed changes

dmathieu mentioned this pull request Nov 21, 2025

[chore] Update core dependencies #44446

Closed

florianl and others added 2 commits November 24, 2025 08:08

Update .chloggen/collector-14188.yaml

9043f4d

Co-authored-by: Vihas Makwana <121151420+VihasMakwana@users.noreply.github.com>

replace deprecated function

8513326

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

florianl added 2 commits November 24, 2025 14:30

[chore] mod and toolchain tidy

83f9b84

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

fix TestCompareProfiles

41392eb

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

mx-psi approved these changes Nov 24, 2025

View reviewed changes

.chloggen/collector-14188.yaml Outdated Show resolved Hide resolved

Update .chloggen/collector-14188.yaml

fb918a2

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>

mx-psi mentioned this pull request Nov 24, 2025

[chore] Update core dependencies #44481

Closed

github-actions bot mentioned this pull request Nov 24, 2025

[exporter/elasticsearchexporter/integrationtest]: Report for failed tests on main #44311

Closed

mx-psi mentioned this pull request Nov 26, 2025

Create changelog entry for breaking change in OTTL profiles #44560

Closed

florianl mentioned this pull request Nov 27, 2025

[chore] add changelog for #44397 #44571

Merged

	return tCtx.GetProfile().DurationNano(), nil
	return time.Unix(0, int64(tCtx.GetProfile().DurationNano())).UTC(), nil

Conversation

florianl commented Nov 19, 2025

Description

Link to tracking issue

Testing

Documentation

Uh oh!

Uh oh!

douglascamata left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mx-psi commented Nov 24, 2025

Uh oh!

edmocosta commented Nov 26, 2025

Uh oh!

mx-psi commented Nov 26, 2025

Uh oh!

edmocosta commented Nov 26, 2025

Uh oh!

mx-psi commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants