Skip to content

[encoding/googlecloudlogentry] Add support for Application Load Balancer Logs#44438

Merged
andrzej-stencel merged 8 commits intoopen-telemetry:mainfrom
alexcams:support-load-balancing-logs
Dec 2, 2025
Merged

[encoding/googlecloudlogentry] Add support for Application Load Balancer Logs#44438
andrzej-stencel merged 8 commits intoopen-telemetry:mainfrom
alexcams:support-load-balancing-logs

Conversation

@alexcams
Copy link
Contributor

@alexcams alexcams commented Nov 20, 2025

Description

This PR adds support for parsing both types of GCP Application Load Balancers (regional and global).
With this changes, the user will be able to see load balancer logs reported information in log attributes instead of pasted as a raw json string into the log body, that could cause the user to overlook important info.

Also modified armor log parsing to allow parse more than one policy types included in a single log entry.

Link to tracking issue

Solves #44274

Testing

Added unit tests for new files and updated existing ones.

Documentation

Updated README.md

@alexcams alexcams requested a review from a team as a code owner November 20, 2025 18:02
@alexcams alexcams requested a review from braydonk November 20, 2025 18:02
@alexcams alexcams marked this pull request as draft November 20, 2025 18:02
@github-actions github-actions bot requested a review from constanca-m November 20, 2025 18:02
@alexcams alexcams changed the title Support load balancing logs [encoding/googlecloudlogentry] Add support for Application Load Balancer Logs Nov 20, 2025
@alexcams alexcams force-pushed the support-load-balancing-logs branch from 3ba83ec to f151583 Compare November 20, 2025 18:23
@alexcams alexcams force-pushed the support-load-balancing-logs branch from eea9127 to 10d22df Compare November 21, 2025 09:49
@alexcams alexcams marked this pull request as ready for review November 21, 2025 10:09
Copy link
Contributor

@constanca-m constanca-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 3 comments, but the rest looks good to me. I no longer see us reading the whole payload like before, is that right? Now we just unmarshal, the armor log struct is part of load balancing

@alexcams alexcams force-pushed the support-load-balancing-logs branch from ea27275 to 217b871 Compare November 25, 2025 08:28
@alexcams alexcams requested a review from constanca-m November 25, 2025 08:29
Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I didn't look through all the code, mostly focused on the mappings.

@constanca-m constanca-m added the ready to merge Code review completed; ready to merge by maintainers label Dec 2, 2025
@andrzej-stencel andrzej-stencel merged commit ecad830 into open-telemetry:main Dec 2, 2025
205 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 2, 2025
@otelbot
Copy link
Contributor

otelbot bot commented Dec 2, 2025

Thank you for your contribution @alexcams! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

joecompute added a commit to elastic/terraform-google-edot-cloud-forwarder that referenced this pull request Jan 13, 2026
This can be considered a breaking change, as some log types will be parsed differently due to additional support. However, we have not gone live with an official release, so the major version will not be bumped. See below for OpenTelemetry Collector-related log parsing changes:

- https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.142.0
  - extension/googlecloudlogentry_encoding: Parse External Application Load Balancer logs into log record attributes instead of placing it in the body as is. (open-telemetry/opentelemetry-collector-contrib#44438)
  - extension/googlecloudlogentry_encoding: Add support for GCP VPC Flow Log fields for MIG (Managed Instance Group) and Google Service logs. (open-telemetry/opentelemetry-collector-contrib#44220)
Adds support for the following GCP VPC Flow Log fields:
- https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.143.0
  - extension/googlecloudlogentry_encoding: Parse Cloud DNS Query logs into log record attributes instead of placing it in the body as is. (open-telemetry/opentelemetry-collector-contrib#44561)
  - extension/googlecloudlogentry_encoding: Add support for Passthrough External and Internal Network Load Balancer logs (open-telemetry/opentelemetry-collector-contrib#44524)
joecompute added a commit to elastic/terraform-google-edot-cloud-forwarder that referenced this pull request Jan 15, 2026
This can be considered a breaking change, as some log types will be parsed differently due to additional support. However, we have not gone live with an official release, so the major version will not be bumped. See below for OpenTelemetry Collector-related log parsing changes:

- https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.142.0
  - extension/googlecloudlogentry_encoding: Parse External Application Load Balancer logs into log record attributes instead of placing it in the body as is. (open-telemetry/opentelemetry-collector-contrib#44438)
  - extension/googlecloudlogentry_encoding: Add support for GCP VPC Flow Log fields for MIG (Managed Instance Group) and Google Service logs. (open-telemetry/opentelemetry-collector-contrib#44220)
Adds support for the following GCP VPC Flow Log fields:
- https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.143.0
  - extension/googlecloudlogentry_encoding: Parse Cloud DNS Query logs into log record attributes instead of placing it in the body as is. (open-telemetry/opentelemetry-collector-contrib#44561)
  - extension/googlecloudlogentry_encoding: Add support for Passthrough External and Internal Network Load Balancer logs (open-telemetry/opentelemetry-collector-contrib#44524)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension/encoding/googlecloudlogentryencoding ready to merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants