[encoding/googlecloudlogentry] Add support for Application Load Balancer Logs#44438
Merged
andrzej-stencel merged 8 commits intoopen-telemetry:mainfrom Dec 2, 2025
Merged
Conversation
3ba83ec to
f151583
Compare
eea9127 to
10d22df
Compare
constanca-m
reviewed
Nov 21, 2025
Contributor
constanca-m
left a comment
There was a problem hiding this comment.
Just 3 comments, but the rest looks good to me. I no longer see us reading the whole payload like before, is that right? Now we just unmarshal, the armor log struct is part of load balancing
extension/encoding/googlecloudlogentryencodingextension/log_entry.go
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
ea27275 to
217b871
Compare
constanca-m
reviewed
Nov 25, 2025
...ooglecloudlogentryencodingextension/testdata/armorlog/enforced_security_policy_expected.yaml
Outdated
Show resolved
Hide resolved
constanca-m
approved these changes
Nov 25, 2025
axw
approved these changes
Dec 1, 2025
Contributor
axw
left a comment
There was a problem hiding this comment.
LGTM! I didn't look through all the code, mostly focused on the mappings.
...extension/testdata/apploadbalancer/regional_external_application_load_balancer_expected.yaml
Show resolved
Hide resolved
Contributor
|
Thank you for your contribution @alexcams! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
joecompute
added a commit
to elastic/terraform-google-edot-cloud-forwarder
that referenced
this pull request
Jan 13, 2026
This can be considered a breaking change, as some log types will be parsed differently due to additional support. However, we have not gone live with an official release, so the major version will not be bumped. See below for OpenTelemetry Collector-related log parsing changes: - https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.142.0 - extension/googlecloudlogentry_encoding: Parse External Application Load Balancer logs into log record attributes instead of placing it in the body as is. (open-telemetry/opentelemetry-collector-contrib#44438) - extension/googlecloudlogentry_encoding: Add support for GCP VPC Flow Log fields for MIG (Managed Instance Group) and Google Service logs. (open-telemetry/opentelemetry-collector-contrib#44220) Adds support for the following GCP VPC Flow Log fields: - https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.143.0 - extension/googlecloudlogentry_encoding: Parse Cloud DNS Query logs into log record attributes instead of placing it in the body as is. (open-telemetry/opentelemetry-collector-contrib#44561) - extension/googlecloudlogentry_encoding: Add support for Passthrough External and Internal Network Load Balancer logs (open-telemetry/opentelemetry-collector-contrib#44524)
joecompute
added a commit
to elastic/terraform-google-edot-cloud-forwarder
that referenced
this pull request
Jan 15, 2026
This can be considered a breaking change, as some log types will be parsed differently due to additional support. However, we have not gone live with an official release, so the major version will not be bumped. See below for OpenTelemetry Collector-related log parsing changes: - https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.142.0 - extension/googlecloudlogentry_encoding: Parse External Application Load Balancer logs into log record attributes instead of placing it in the body as is. (open-telemetry/opentelemetry-collector-contrib#44438) - extension/googlecloudlogentry_encoding: Add support for GCP VPC Flow Log fields for MIG (Managed Instance Group) and Google Service logs. (open-telemetry/opentelemetry-collector-contrib#44220) Adds support for the following GCP VPC Flow Log fields: - https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.143.0 - extension/googlecloudlogentry_encoding: Parse Cloud DNS Query logs into log record attributes instead of placing it in the body as is. (open-telemetry/opentelemetry-collector-contrib#44561) - extension/googlecloudlogentry_encoding: Add support for Passthrough External and Internal Network Load Balancer logs (open-telemetry/opentelemetry-collector-contrib#44524)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for parsing both types of GCP Application Load Balancers (regional and global).
With this changes, the user will be able to see load balancer logs reported information in log attributes instead of pasted as a raw json string into the log body, that could cause the user to overlook important info.
Also modified armor log parsing to allow parse more than one policy types included in a single log entry.
Link to tracking issue
Solves #44274
Testing
Added unit tests for new files and updated existing ones.
Documentation
Updated README.md