Skip to content

[chore][receiver/googlecloudpubsub] update to cloud.google.com/go/pub…#44466

Merged
atoulme merged 2 commits intoopen-telemetry:mainfrom
alexvanboxel:pubsubreceiver-pubsubv2
Nov 25, 2025
Merged

[chore][receiver/googlecloudpubsub] update to cloud.google.com/go/pub…#44466
atoulme merged 2 commits intoopen-telemetry:mainfrom
alexvanboxel:pubsubreceiver-pubsubv2

Conversation

@alexvanboxel
Copy link
Contributor

@alexvanboxel alexvanboxel commented Nov 22, 2025

Description

Update to the cloud.google.com/go/pubsub/v2 package to keep the Renovate bot happy.

This PR is scoped to the receiver/googlepubsubreceiver

Link to tracking issue

This PR fixes renovate trying to upgrade but can't because it requires code changes:
#42871

And remove the Pubsub part in the combined deprecation fix PR:
#41646

Testing

Changed existing test to match the new API.

Documentation

No documentation change required.

@alexvanboxel
Copy link
Contributor Author

/label receiver/googlepubsubreceiver waiting-for-code-owners

@alexvanboxel alexvanboxel force-pushed the pubsubreceiver-pubsubv2 branch from 5b14142 to bb63559 Compare November 24, 2025 10:19
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, @alexvanboxel! Do you think adding a changelog would be helpful here since it's a major version upgrade, or is the expectation that this does not impact users in any way? (If there's a chance this impacts users, I'd tend to lean towards adding a changelog just in case)

@alexvanboxel
Copy link
Contributor Author

Thanks for taking care of this, @alexvanboxel! Do you think adding a changelog would be helpful here since it's a major version upgrade, or is the expectation that this does not impact users in any way? (If there's a chance this impacts users, I'd tend to lean towards adding a changelog just in case)

I think the risk is low because I use the pure gRPC contracts as the client itself hides too much. If it needs a changelog, I should do one for the exporter as well. What should the change type be... enhancement?

@crobert-1
Copy link
Member

What should the change type be... enhancement?

I think enhancement would make the most sense. If you're up for it, I'd say we may as well add them. There's no harm in adding a changelog here, and it may be helpful.

@alexvanboxel alexvanboxel force-pushed the pubsubreceiver-pubsubv2 branch from bb63559 to d3540fa Compare November 24, 2025 20:54
@alexvanboxel
Copy link
Contributor Author

Rebased and added an extra commit with the 2 changelogs for the exporter and receiver.

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Nov 24, 2025
@atoulme atoulme merged commit 11ab64b into open-telemetry:main Nov 25, 2025
205 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Code review completed; ready to merge by maintainers receiver/googlecloudpubsub

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants