[exporter/elasticsearch]: add dynamic data stream routing for connectors#44525
Merged
ChrsMark merged 6 commits intoopen-telemetry:mainfrom Dec 10, 2025
Merged
[exporter/elasticsearch]: add dynamic data stream routing for connectors#44525ChrsMark merged 6 commits intoopen-telemetry:mainfrom
ChrsMark merged 6 commits intoopen-telemetry:mainfrom
Conversation
rogercoll
changed the title
florianl
approved these changes
Nov 28, 2025
Member
|
@JaredTan95, @carsonip and @lahsivjar please review as codeowners |
carsonip
reviewed
Dec 10, 2025
Comment on lines
+18
to
+21
| var componentsRegex = []*regexp.Regexp{ | ||
| regexp.MustCompile(`/receiver/(\w+receiver)`), | ||
| regexp.MustCompile(`/connector/(\w+connector)`), | ||
| } |
Contributor
There was a problem hiding this comment.
Q: have you considered merging them to 1 regex instead of having 2 regex in a slice?
Contributor
Author
There was a problem hiding this comment.
Yes, not a strong opinion, but I decided to go with the slice for better performance based on expected usage (mostly receivers), specifically by prioritizing the early exit logic and avoiding the extra capturing computation.
carsonip
approved these changes
Dec 10, 2025
Contributor
carsonip
left a comment
carsonip
left a comment
There was a problem hiding this comment.
approving to unblock as i don't have a strong opinion on 1 regex vs 2 regex
ChrsMark
reviewed
Dec 10, 2025
ChrsMark
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the data stream dynamic routing rules to include telemetry generated/instrumented by a connector (scope name).
Link to tracking issue
Fixes #44525
Testing
Documentation