[receiver/kafka] Remove deprecated legacy topic and encoding#44568
Merged
atoulme merged 3 commits intoopen-telemetry:mainfrom Nov 27, 2025
Merged
[receiver/kafka] Remove deprecated legacy topic and encoding#44568atoulme merged 3 commits intoopen-telemetry:mainfrom
atoulme merged 3 commits intoopen-telemetry:mainfrom
Conversation
khushijain21
requested review from
a team,
MovieStoreGuy and
axw
as code owners
khushijain21
changed the title
6 tasks
github-merge-queue bot
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Dec 5, 2025
…tConn and Kafka receiver/exporter (#7694) ## 🛑 Breaking Change This upgrade of dependencies from OTel Collector introduces a breaking change in the Kafka exporter and receiver configuration: the `topic` and `encoding` fields moved under `traces` element (open-telemetry/opentelemetry-collector-contrib#44568). Before: ```yaml exporters: kafka: brokers: - localhost:9092 topic: ${env:KAFKA_TOPIC:-jaeger-spans} encoding: ${env:KAFKA_ENCODING:-otlp_proto} ``` After: ```yaml exporters: kafka: brokers: - localhost:9092 traces: topic: ${env:KAFKA_TOPIC:-jaeger-spans} encoding: ${env:KAFKA_ENCODING:-otlp_proto} ``` ## Fix for OTel Collector Upgrade PR #7694 ✅ - [x] Identify the failing build - Segmentation fault in TestNewServer_TLSConfigError - [x] Analyze error messages - Nil pointer dereference when calling Host.GetExtensions() - [x] Research and apply fix: - Added nil checks before calling Host.GetExtensions() in 3 locations - If Host is nil, pass nil to ToServer/ToClientConn instead of dereferencing - [x] Fix Kafka receiver/exporter configuration breaking changes - Moved `topic` and `encoding` into signal-specific `traces` section - Updated both `config-kafka-ingester.yaml` and `config-kafka-collector.yaml` - [x] Test the build passes - [x] Verify the changes are minimal and correct ## Summary Fixed build failures caused by breaking changes in OTel Collector v0.141.0: ### 1. ToServer/ToClientConn API Changes Added nil pointer checks before calling `Host.GetExtensions()` in: - `cmd/remote-storage/app/server.go` (added import and nil check) - `cmd/query/app/server.go` (2 locations with nil checks) ### 2. Kafka Receiver/Exporter Configuration Changes The Kafka receiver v0.141.0 removed deprecated top-level `topic` and `encoding` fields. Updated configuration files: - `cmd/jaeger/config-kafka-ingester.yaml` - Moved topic/encoding under `traces` section - `cmd/jaeger/config-kafka-collector.yaml` - Moved topic/encoding under `traces` section All tests now pass including the previously failing `TestNewServer_TLSConfigError` and Kafka integration tests. ✅ <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > investigate why this upgrade PR is failing the build/CI: #7692 </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yurishkuro <3523016+yurishkuro@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Dec 5, 2025
…tConn and Kafka receiver/exporter (#7694) ## 🛑 Breaking Change This upgrade of dependencies from OTel Collector introduces a breaking change in the Kafka exporter and receiver configuration: the `topic` and `encoding` fields moved under `traces` element (open-telemetry/opentelemetry-collector-contrib#44568). Before: ```yaml exporters: kafka: brokers: - localhost:9092 topic: ${env:KAFKA_TOPIC:-jaeger-spans} encoding: ${env:KAFKA_ENCODING:-otlp_proto} ``` After: ```yaml exporters: kafka: brokers: - localhost:9092 traces: topic: ${env:KAFKA_TOPIC:-jaeger-spans} encoding: ${env:KAFKA_ENCODING:-otlp_proto} ``` ## Fix for OTel Collector Upgrade PR #7694 ✅ - [x] Identify the failing build - Segmentation fault in TestNewServer_TLSConfigError - [x] Analyze error messages - Nil pointer dereference when calling Host.GetExtensions() - [x] Research and apply fix: - Added nil checks before calling Host.GetExtensions() in 3 locations - If Host is nil, pass nil to ToServer/ToClientConn instead of dereferencing - [x] Fix Kafka receiver/exporter configuration breaking changes - Moved `topic` and `encoding` into signal-specific `traces` section - Updated both `config-kafka-ingester.yaml` and `config-kafka-collector.yaml` - [x] Test the build passes - [x] Verify the changes are minimal and correct ## Summary Fixed build failures caused by breaking changes in OTel Collector v0.141.0: ### 1. ToServer/ToClientConn API Changes Added nil pointer checks before calling `Host.GetExtensions()` in: - `cmd/remote-storage/app/server.go` (added import and nil check) - `cmd/query/app/server.go` (2 locations with nil checks) ### 2. Kafka Receiver/Exporter Configuration Changes The Kafka receiver v0.141.0 removed deprecated top-level `topic` and `encoding` fields. Updated configuration files: - `cmd/jaeger/config-kafka-ingester.yaml` - Moved topic/encoding under `traces` section - `cmd/jaeger/config-kafka-collector.yaml` - Moved topic/encoding under `traces` section All tests now pass including the previously failing `TestNewServer_TLSConfigError` and Kafka integration tests. ✅ <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > investigate why this upgrade PR is failing the build/CI: #7692 </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yurishkuro <3523016+yurishkuro@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the deprecated topic and encoding config