[receiver/datadog] Make gRPC, HTTP, and AWS-SDK spans compliant with the OTel Semconv#44702
Conversation
dehaansa
left a comment
There was a problem hiding this comment.
One question, and needs a changelog, otherwise LGTM
| func processGRPCSpan(span *pb.Span, newSpan *ptrace.Span) { | ||
| // ddSpan.Attributes["grpc.status.code"] contains the gRPC status code name (eg "OK") | ||
| // not the numeric value (eg "0") | ||
| // it's ddSpan.error that indicates whether the status code value |
There was a problem hiding this comment.
(nit) this seems to be missing a word
|
As seen with @xiu , does work with RPC spans produced by dd-trace-java that use slightly different span tags |
|
Build failing due to flaky tests that are not related to this PR |
| @@ -0,0 +1,30 @@ | |||
| # Use this changelog template to create an entry for release notes. | |||
There was a problem hiding this comment.
You are adding changelogs from other PRs or something.
There was a problem hiding this comment.
This PR contains several distinct but related improvements so I created multiple change log files.
dehaansa
left a comment
There was a problem hiding this comment.
LGTM. I don't have a strong opinion on multiple changelogs from one PR, I don't see anything in the contributing.md that explicitly states only one per PR, seems like added clarity is always good.
Description
http.requestandweb.requestspan names compliant with OTel semconvdb.instancetag is now mapped to the OTel attributedb.namespaceinstead ofdb.collection.name.db.sql.tabletag is mapped to the OTel attributedb.collection.name.db.statementtag is mapped to the OTel attributedb.query.text.rpc.system,rpc.methodandrpc.serviceattributes.runtimeis now mapped to the OTel attributecontainer.runtime.nameinstead ofcontainer.runtime.Link to tracking issue
Fixes:
Testing
End to end test with dd-trace-java
gRPC span
HTTP request span
Documentation