Add stored procedure information to Oracle DB receiver logs#44764
Add stored procedure information to Oracle DB receiver logs#44764atoulme merged 20 commits intoopen-telemetry:mainfrom
Conversation
akshays-19
requested review from
a team,
atoulme,
crobert-1 and
dmitryax
as code owners
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
|
Please add a changelog and mark ready to review when this is no longer considered WIP. |
…ect name of stored procedure information
akshays-19
changed the title
added changelog, ready for review |
crobert-1
left a comment
crobert-1
left a comment
There was a problem hiding this comment.
Looks like the CI/CD failures are related to this PR, please review and update
…NAME, and PROCEDURE_TYPE Fixed lint issues which was causing CI/CD failures
…ays-19/opentelemetry-collector-contrib into Oracle_Stored_Procedures_v2
|
LGTM |
There was a problem hiding this comment.
I'm pretty confused here about removing object_name and object_type, then adding procedure_name and procedure_type. Can you clarify, are these simply renames or is it more than that?
If we're renaming/removing attributes, we need to make it a breaking change in the changelog, and make it as clear as possible what's going on here.
There was a problem hiding this comment.
The topNquery did not have procedure related data earlier, so that is newly added.
In case of querySamples, we updated variables from object_ to procedure_ for consistency.
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
|
Thank you for your contribution @akshays-19! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
…emetry#44764) #### Description oracledbreceiver currently fetches top queries and query_samples information. This PR will also fetch the stored procedure information as well. It will primarily fetch procedure id, name, owner and type. Changes include: - Add PROGRAM_ID, OWNER, OBJECT_NAME, OBJECT_TYPE columns to oracleQueryMetricsAndTextSql.tmpl - Add OBJECT_ID column to oracleQuerySampleSql.tmpl - Add DBA_PROCEDURES join to both templates for stored procedure lookup - Add new attributes: oracledb.object_id, oracledb.object_owner, oracledb.object_name, oracledb.object_type - Update scraper.go to parse and pass stored procedure attributes - Update test data and expected outputs --------- Co-authored-by: Dmitry Anoshin <anoshindx@gmail.com> Co-authored-by: Curtis Robert <crobert@splunk.com>
8 participants
Description
oracledbreceiver currently fetches top queries and query_samples information. This PR will also fetch the stored procedure information as well. It will primarily fetch procedure id, name, owner and type.
Changes include: