[transator/azurelogs] Add support for the remaining activity logs categories#44871
Conversation
e84b5d8 to
f452454
Compare
|
Hey @thompson-tomo, thank you for kicking off the review! All the suggestions I see make sense. What are the best resources to get started with naming conventions in semconv, so I can avoid making n00b choices? |
|
No worries at all. A good place to start would be https://opentelemetry.io/docs/specs/semconv/general/naming/ & https://opentelemetry.io/docs/specs/semconv/how-to-write-conventions/ there are tasks to improve those docs. Also a good understanding can be gained by reviewing what is already defined. The way I like to think during attribute naming is what is the item that is being described. That becomes the 2nd last namespace with the last being a property of the item you are capturing. |
b2fb2a7 to
73b3ca0
Compare
c21d57f to
82a32e7
Compare
|
@constanca-m, @MikeGoldsmith, @atoulme, Could you take a look at this PR when you have a chance? 🙇 I also plan to port these log categories to extension/encoding/azureencodingextension when #44919 is merged. |
While we're on the subject of the new It would be a better user experience to have all eight categories supported instead of just the one. Let me know if you feel differently! |
constanca-m
left a comment
There was a problem hiding this comment.
The mapping looks very good! Just 2 questions about it
constanca-m
left a comment
There was a problem hiding this comment.
Thanks Maurizio, I took a final look and all seems good
9f4c509 to
675cbfa
Compare
675cbfa to
f6d4332
Compare
|
@atoulme, let me know if you think this PR needs changes whenever you have a moment 🙇 |
Includes support for: - Administrative - Alert - Autoscale - Policy - Resource Health - Security - Service Health # Conflicts: # pkg/translator/azurelogs/resourcelogs_to_logs.go # pkg/translator/azurelogs/testdata/recommendation/valid_1_expected.yaml
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Co-authored-by: Constança Manteigas <113898685+constanca-m@users.noreply.github.com>
azure.identity.identifier.name > user.name
f6d4332 to
e9eb91d
Compare
|
Hey @atoulme, sorry to bother you again, but I believe the PR is good to go for a final look whenever you have a moment! 🙇 |
|
I'm going to remove the |
Thanks for the clarification, @ChrsMark. I don't really know what to do next to wrap up this PR, it has been open for more than a month. I would love to complete the review of these changes before porting them to the new extension/azure_encoding. |
What needs to happen here is to get an approval from the PR's facilitator (or another approver). You correctly pinged the PR's assigned approver at #44871 (comment) so let's give some time to Antoine to get to this. In case there is still delay feel free to raise this in CNCF slack (#otel-collector-dev channel). FYI, I filed a PR to update the docs accordingly regarding the use of |
atoulme
left a comment
There was a problem hiding this comment.
Looks better than before. Merging.
|
Thank you for your contribution @zmoog! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
…oscale, Policy, Security, ServiceHealth, and ResourceHealth log categories. (#45699) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR brings over the remaining Activity log categories from `translator/azurelogs`, aligning this component with the changes made in #44871. New log categories: - Administrative - Alert - Autoscale - Policy - Security - ServiceHealth - ResourceHealth <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. #### Link to tracking issue Fixes n/a --> <!--Describe what testing was performed and which tests were added.--> #### Testing We added test cases for each category, leveraging the same log events found in translator/azurelogs for consistency. <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Added a section covering Identity (including its major subfields) along with dedicated sections for each new log category. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
Description
Includes support for all the remaining seven Activity log categories:
The PR is built on top of the PR #43220 that added support for the Recommendation log category.
It applies the same philosophy:
Note for reviewers: I'm not 100% on the field naming convention, so your feedback and insight are really needed here.
Link to tracking issue
N/A
Testing
I collected some sample logs from actual Azure and anonymized a little bit for the following log categories:
However, I wasn't able to get actual log events for the following categories, so I inferred them from samples available in the Azure docs (which seems to use the Log Analytics Workspace format):
Please pay extra attention when reviewing these categories, and please let me know if you're able to share some actual samples from Azure.
Documentation
N/A