Add export traces to gcs#44945
Conversation
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
cd8be36 to
3d817ff
Compare
constanca-m
left a comment
There was a problem hiding this comment.
Thanks for the contribution Gil, usually it is best to start with opening an issue instead of opening the PR already, just to make sure we can have agreement before implementation.
The PR looks good in general, just a couple of concerns
8ff9140 to
4a98624
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
4a98624 to
d2529dc
Compare
|
@constanca-m, I'm sorry I took too long to fix your review comments. I've been sick for a while. |
f92dc8c to
0efa8e4
Compare
constanca-m
left a comment
There was a problem hiding this comment.
Thanks, almost there
0efa8e4 to
a7d5d43
Compare
|
I've also rebased this branch with the latest commits from the |
constanca-m
left a comment
There was a problem hiding this comment.
Thanks @gafda, looks good
7e7e380 to
e8e944d
Compare
|
@gafda You need to fix the lint errors for the PR to get merged |
e8e944d to
f9378be
Compare
Co-authored-by: ctorrao <22594902+ctorrao@users.noreply.github.com>
Co-authored-by: ctorrao <22594902+ctorrao@users.noreply.github.com>
… usage in exporter feat: enhance OpenTelemetry collector configuration with Prometheus support and improved metrics handling
…ust stability levels
…and encoding validation
- Simplify early-return pattern in traces marshaler loading - Remove unused parameter from loadExtension function - Fix struct field formatting in test file - Add changelog entry for traces export support
f9378be to
ba9464d
Compare
|
@constanca-m This branch is now up-to-date with |
|
Thank you for your contribution @gafda! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
This pull request adds support for exporting traces, in addition to logs, to Google Cloud Storage in the
googlecloudstorageexporter. It updates the configuration, implementation, and tests to handle traces, and improves how encoding extensions are loaded for both logs and traces.Traces Export Support:
ConsumeTraces, trace marshaling, and registration of the traces exporter. [1] [2] [3] [4] [5]Configuration and Documentation Updates:
README.mdandmetadata.yamlto reflect support for traces and clarify how theencodingoption works for both logs and traces. [1] [2] [3]Configuration Handling Improvements:
Encodingfield in the config struct from a pointer to a value, simplifying usage and reducing nil checks. [1] [2]Testing Enhancements:
Configuration Example: