[receiver/tcpcheck] fix metric unit#45092
Merged
atoulme merged 1 commit intoopen-telemetry:mainfrom Jan 1, 2026
Merged
Conversation
atoulme
commented
Dec 20, 2025
github-actions
bot
requested review from
chengchuanpeng,
michael-burt and
yanfeng1992
VihasMakwana
approved these changes
Dec 31, 2025
| m.data.SetName("tcpcheck.error") | ||
| m.data.SetDescription("Records errors occurring during TCP check.") | ||
| m.data.SetUnit("{error}") | ||
| m.data.SetUnit("{errors}") |
Member
There was a problem hiding this comment.
Doesn't this contradict the docs? https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-units
All non-units that use curly braces to annotate a quantity need to match the grammatical number of the quantity it represent. For example if measuring the number of individual requests to a process the unit would be {request}, not {requests}.
Contributor
Author
There was a problem hiding this comment.
I am confused. I was under the strong impression it was the other way around. I will open an issue.
seongpil0948
pushed a commit
to seongpil0948/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2026
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fix the unit metric from `error` to `errors`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the unit metric from
errortoerrors