[receiver/fluentforward] Ensure all established connections are properly closed on shutdown#45145
Merged
atoulme merged 1 commit intoopen-telemetry:mainfrom Jan 1, 2026
Conversation
|
|
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
tokuhirom
force-pushed
the
feature/fluentforward-connection-close-on-shutdown-44433
branch
from
d50d660 to
829517a
Compare
…rly closed on shutdown Fixes shutdown behavior so that all existing connections are closed cleanly. Adds tests to verify proper connection closure. Fixes open-telemetry#44433
tokuhirom
force-pushed
the
feature/fluentforward-connection-close-on-shutdown-44433
branch
from
829517a to
de2d83e
Compare
atoulme
reviewed
Dec 28, 2025
|
|
||
| func (s *server) closeAllConns() { | ||
| s.mu.Lock() | ||
| for c := range s.conns { |
Contributor
There was a problem hiding this comment.
no need, the connections will exit and delete from the map.
atoulme
approved these changes
Dec 31, 2025
Contributor
|
Thank you for your contribution @tokuhirom! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
seongpil0948
pushed a commit
to seongpil0948/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2026
…rly closed on shutdown (open-telemetry#45145) Fixes shutdown behavior so that all existing connections are closed cleanly. Adds tests to verify proper connection closure. <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description open-telemetry#44433 #### Link to tracking issue Fixes open-telemetry#44433 #### Testing Add the test case to check the connection closed. #### Documentation -
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes shutdown behavior so that all existing connections are closed cleanly. Adds tests to verify proper connection closure.
Description
#44433
Link to tracking issue
Fixes #44433
Testing
Add the test case to check the connection closed.
Documentation