[extension/datadog] Remove extension check error when getting active components#45358
Conversation
extension/datadogextension/internal/componentchecker/componentchecker.go
Show resolved
Hide resolved
|
(Arguably this is a bug on the Datadog Agent side for not filling in some of the module info, but I agree an error is excessive) |
Agreed, I'm going to open a ticket to revisit this but I don't believe the active components list is currently being used in the fleet UI (will double check this) |
I don't think it's used in the UI right now, but adding it is on the roadmap for this quarter. I don't think it's that big of a deal, but I think a slightly better long-term solution may be to remove the But we can work on that (and maybe extending the fallback behavior to other component kinds) once it becomes necessary. |
Good point, I opened a PR to remove the |
Description
Skips adding extension to list of active components instead of throwing an error when the extension is not found in the module info. This error occurs for custom components in the datadog-agent repo such as the ddflareextension, but this behavior of throwing an error is inconsistent with how we handle pipelines in the same function: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/datadogextension/internal/componentchecker/componentchecker.go#L171-L177.
Link to tracking issue
Fixes
Testing
Added unit test
Documentation