Skip to content

[extension/datadog] Remove extension check error when getting active components#45358

Merged
songy23 merged 3 commits intoopen-telemetry:mainfrom
liustanley:stanley.liu/fix-extension-check
Jan 14, 2026
Merged

[extension/datadog] Remove extension check error when getting active components#45358
songy23 merged 3 commits intoopen-telemetry:mainfrom
liustanley:stanley.liu/fix-extension-check

Conversation

@liustanley
Copy link
Contributor

Description

Skips adding extension to list of active components instead of throwing an error when the extension is not found in the module info. This error occurs for custom components in the datadog-agent repo such as the ddflareextension, but this behavior of throwing an error is inconsistent with how we handle pipelines in the same function: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/datadogextension/internal/componentchecker/componentchecker.go#L171-L177.

Link to tracking issue

Fixes

Testing

Added unit test

Documentation

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a changelog

@jade-guiton-dd
Copy link
Contributor

(Arguably this is a bug on the Datadog Agent side for not filling in some of the module info, but I agree an error is excessive)

@liustanley
Copy link
Contributor Author

(Arguably this is a bug on the Datadog Agent side for not filling in some of the module info, but I agree an error is excessive)

Agreed, I'm going to open a ticket to revisit this but I don't believe the active components list is currently being used in the fleet UI (will double check this)

@songy23 songy23 merged commit ccd6068 into open-telemetry:main Jan 14, 2026
191 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 14, 2026
@jade-guiton-dd
Copy link
Contributor

jade-guiton-dd commented Jan 15, 2026

Agreed, I'm going to open a ticket to revisit this but I don't believe the active components list is currently being used in the fleet UI (will double check this)

I don't think it's used in the UI right now, but adding it is on the roadmap for this quarter. I don't think it's that big of a deal, but I think a slightly better long-term solution may be to remove the continue statement, so that we the extension is still in the active list, but we're just missing the gomod/version information for it.

But we can work on that (and maybe extending the fallback behavior to other component kinds) once it becomes necessary.

@liustanley
Copy link
Contributor Author

Agreed, I'm going to open a ticket to revisit this but I don't believe the active components list is currently being used in the fleet UI (will double check this)

I don't think it's used in the UI right now, but adding it is on the roadmap for this quarter. I don't think it's that big of a deal, but I think a slightly better long-term solution may be to remove the continue statement, so that we the extension is still in the active list, but we're just missing the gomod/version information for it.

But we can work on that (and maybe extending the fallback behavior to other component kinds) once it becomes necessary.

Good point, I opened a PR to remove the continue statement so that we can include this change in the DDOT datadog extension release: #45460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants