-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
release:required-for-gaMust be resolved before GA releaseMust be resolved before GA release
Milestone
Description
This is a preparation for pdata (TraceID, SpanID, AttributeValue, AttributeMap) to be marked as stable API.
- Cleanup translator code to work only with pdata types (TraceID, SpanID)
- Should we consider to move translator code as helper to pdata (NewTraceIDFromLong, NewSpanIDFromLong, etc.). Translator code is in translator/trace/big_endian_converter?
- Review public API for TraceID, SpanID - Punya
- Review public API for AttributeValue and AttributeMap.
- One thing that we should consider is to rename
ForEachwithRangeto be consistent withsync.Map. - Remove deprecated
NewAttributeValue, needs changes in pdatagen which is the only user of this. - Remove
InitEmptyWithCapacity - Add
EnsureCapacity(replacement forInitEmptyWithCapacity) that does not remove existing elements.
- One thing that we should consider is to rename
- Review comments for all public API, maybe we have things to improve. - Punya
- Review the
Resizeapi for slices.- MAY consider to replace the API with
EnsureCapacity+AppendEmptyusage. OrAppendEmptyN(int).
- MAY consider to replace the API with
- Remove deprecated
Resize- Anthony - Remove deprecated
Appendapi for slices.- Cleanup core usages of
pdata.Append. - Cleanup contrib usages of
pdata.Append.
- Cleanup core usages of
- Consider to change StartTime/EndTime to StartTimestamp/EndTimestamp
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
release:required-for-gaMust be resolved before GA releaseMust be resolved before GA release