system/telemetry metrics OTLP GRPC Exporter: add CA certificate support#11633
Merged
codeboten merged 8 commits intoopen-telemetry:mainfrom Nov 27, 2024
Merged
system/telemetry metrics OTLP GRPC Exporter: add CA certificate support#11633codeboten merged 8 commits intoopen-telemetry:mainfrom
codeboten merged 8 commits intoopen-telemetry:mainfrom
Conversation
dmathieu
reviewed
Nov 12, 2024
Member
dmathieu
left a comment
dmathieu
left a comment
There was a problem hiding this comment.
This will need a changelog entry.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11633 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 442 442
Lines 23776 23781 +5
=======================================
+ Hits 21787 21792 +5
Misses 1618 1618
Partials 371 371 ☔ View full report in Codecov by Sentry. |
Contributor
Author
@dmathieu, changelog was added and I fixed the lint issue. Waiting for a review/approval. |
Member
|
Can you run |
Contributor
Author
@dmathieu, Done. |
dmathieu
approved these changes
Nov 21, 2024
Contributor
Author
|
Hi @codeboten, it looks like this is blocked on your final review. This is quite a small change; could you take a look when you get a chance? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for CA certificates to the OTLP gRPC exporter for metrics in system/telemetry.
Currently if a "Certificate" is specified in the config, it is silently ignored.
Testing
Both a positive and negative unit test was added.
The good test CA certificate was copied from another unit test.
I'm going to file an issue for updating all test certificates as all the ones I checked seem to expire in 2032 which is only 8 years away.
Documentation
None.