Skip to content

[chore][mdatagen] Fix metrics test bug with resource attributes#15008

Merged
codeboten merged 2 commits intoopen-telemetry:mainfrom
crobert-1:fix_mdatagen_metricsbuilder_test
Mar 27, 2026
Merged

[chore][mdatagen] Fix metrics test bug with resource attributes#15008
codeboten merged 2 commits intoopen-telemetry:mainfrom
crobert-1:fix_mdatagen_metricsbuilder_test

Conversation

@crobert-1
Copy link
Copy Markdown
Member

Description

When a test manually overrides the default value for a resource attribute, the test needs to account for warnings logged when the resource attribute is enabled.

Link to tracking issue

Fixes #15007

@crobert-1 crobert-1 requested review from a team and dmitryax as code owners March 25, 2026 22:57
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.20%. Comparing base (6a56478) to head (eee6fba).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15008      +/-   ##
==========================================
- Coverage   91.22%   91.20%   -0.02%     
==========================================
  Files         697      697              
  Lines       44627    44627              
==========================================
- Hits        40710    40704       -6     
- Misses       2773     2777       +4     
- Partials     1144     1146       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeboten codeboten enabled auto-merge March 27, 2026 22:09
@codeboten codeboten added this pull request to the merge queue Mar 27, 2026
Merged via the queue into open-telemetry:main with commit 85f1268 Mar 27, 2026
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cmd/mdatagen] Test bug for disabled by default resource attributes with warnings

3 participants