Add jaeger thrift-http exporter#228
Merged
pjanotti merged 1 commit intoopen-telemetry:masterfrom Aug 5, 2019
Merged
Conversation
Adds the Jaeger Thrift over HTTP exporter.
pjanotti
requested review from
bogdandrutu,
flands,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 72.79% 73.33% +0.53%
==========================================
Files 110 110
Lines 6338 6365 +27
==========================================
+ Hits 4614 4668 +54
+ Misses 1491 1458 -33
- Partials 233 239 +6
Continue to review full report at Codecov.
|
songy23
approved these changes
Aug 3, 2019
|
|
||
| // URL is the URL to send the Jaeger trace data to (e.g.: | ||
| // http://some.url:14268/api/traces). | ||
| URL string `mapstructure:"url"` |
Member
There was a problem hiding this comment.
Nit: can we use endpoint to be consistent with other configs?
Contributor
Author
There was a problem hiding this comment.
We have been consistent on endpoint for receivers because they should always take the same syntax (host:port) but for exporters we had a different conversation in one previous PR: #207 (comment) let's know if you agree with that.
tigrannajaryan
approved these changes
Aug 5, 2019
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Update metrics API to match current spec * update options to match the spec * drop the global meter API * more docs * get rid of leftover mentions about descriptor
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Also sets required path env vars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Jaeger Thrift over HTTP exporter.
Fixes #36
Opportunistically fixes #227 by removing remaining related code.