Remove support for deprecated unmarshaler#2591
Merged
bogdandrutu merged 2 commits intoopen-telemetry:mainfrom Mar 5, 2021
Merged
Remove support for deprecated unmarshaler#2591bogdandrutu merged 2 commits intoopen-telemetry:mainfrom
bogdandrutu merged 2 commits intoopen-telemetry:mainfrom
Conversation
Updates open-telemetry#2540 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
rmdeprecatedunmarshaler
branch
from
d9f899c to
57d8f01
Compare
Codecov Report
@@ Coverage Diff @@
## main #2591 +/- ##
==========================================
- Coverage 92.03% 92.03% -0.01%
==========================================
Files 273 273
Lines 15455 15449 -6
==========================================
- Hits 14224 14218 -6
Misses 849 849
Partials 382 382
Continue to review full report at Codecov.
|
Member
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
Are there any contrib components that still use deprecated CustomUnmarshaler or all are fixed now?
Member
Author
|
@tigrannajaryan all are fixed and they are switched also to the helper "WithCustomUnmarshaler" from components helpers |
tigrannajaryan
approved these changes
Mar 5, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #2540