Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions exporter/loggingexporter/logging_exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
"go.opentelemetry.io/collector/config/configmodels"
"go.opentelemetry.io/collector/consumer/pdata"
"go.opentelemetry.io/collector/exporter/exporterhelper"
tracetranslator "go.opentelemetry.io/collector/translator/trace"
)

type logDataBuffer struct {
Expand Down Expand Up @@ -280,6 +281,8 @@ func attributeValueToString(av pdata.AttributeValue) string {
return strconv.FormatInt(av.IntVal(), 10)
case pdata.AttributeValueARRAY:
return attributeValueArrayToString(av.ArrayVal())
case pdata.AttributeValueMAP:
return attributeMapToString(av.MapVal())
default:
return fmt.Sprintf("<Unknown OpenTelemetry attribute value type %q>", av.Type())
}
Expand All @@ -300,6 +303,17 @@ func attributeValueArrayToString(av pdata.AnyValueArray) string {
return b.String()
}

func attributeMapToString(av pdata.AttributeMap) string {
var b strings.Builder
b.WriteString("{\n")

av.Sort().ForEach(func(k string, v pdata.AttributeValue) {
fmt.Fprintf(&b, " -> %s: %s(%s)\n", k, v.Type(), tracetranslator.AttributeValueToString(v, false))
})
b.WriteByte('}')
return b.String()
}

type loggingExporter struct {
logger *zap.Logger
debug bool
Expand Down
19 changes: 19 additions & 0 deletions exporter/loggingexporter/logging_exporter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,22 @@ func TestNestedArraySerializesCorrectly(t *testing.T) {
assert.Equal(t, 3, ava.ArrayVal().Len())
assert.Equal(t, "[foo, 42, [bar]]", attributeValueToString(ava))
}

func TestNestedMapSerializesCorrectly(t *testing.T) {
ava := pdata.NewAttributeValueMap()
av := ava.MapVal()
av.Insert("foo", pdata.NewAttributeValueString("test"))

ava2 := pdata.NewAttributeValueMap()
av2 := ava2.MapVal()
av2.InsertInt("bar", 13)
av.Insert("zoo", ava2)

expected := `{
-> foo: STRING(test)
-> zoo: MAP({"bar":13})
}`

assert.Equal(t, 2, ava.MapVal().Len())
assert.Equal(t, expected, attributeValueToString(ava))
}