loggingexporter: fix handling the loop for empty attributes#2610
Merged
tigrannajaryan merged 1 commit intoopen-telemetry:mainfrom Mar 5, 2021
Merged
Conversation
pmm-sumo
changed the title
pmm-sumo
changed the title
dmolenda-sumo
approved these changes
Mar 5, 2021
Codecov Report
@@ Coverage Diff @@
## main #2610 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 271 271
Lines 15446 15446
=======================================
Hits 14214 14214
Misses 850 850
Partials 382 382
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Mar 5, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When span was containing several events, only the first one was printed out by the logging exporter. After checking the code it, turned out that handling the case with no attributes returns from the iteration loop altogether, which is wrong. The same bug was introduced for span links.
Link to tracking Issue: N/A
Testing: Just manual tests performed for Span Events
Documentation: N/A