Add initial implementation of pdatagrcp#3231
Merged
bogdandrutu merged 2 commits intoopen-telemetry:mainfrom May 19, 2021
Merged
Add initial implementation of pdatagrcp#3231bogdandrutu merged 2 commits intoopen-telemetry:mainfrom
bogdandrutu merged 2 commits intoopen-telemetry:mainfrom
Conversation
Member
|
@bogdandrutu Please add some notes in the PR description that clarify why this change is needed. |
Member
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
Idea LGTM, just one minor question.
| // LogsClient is the client API for OTLP-GRPC Logs service. | ||
| // | ||
| // For semantics around ctx use and closing/ending streaming RPCs, please refer to https://godoc.org/google.golang.org/grpc#ClientConn.NewStream. | ||
| type LogsClient interface { |
Member
There was a problem hiding this comment.
Do we need an interface? I assume there will be only one implementation ever. Should we simply, delete the interface and just have the struct?
Member
Author
There was a problem hiding this comment.
I can either expose the struct or the interface. I think exposing the interface is more future proof, because we can offer alternative implementations in the future. Not a big thing though, so if you feel strong I can change.
Member
There was a problem hiding this comment.
Not a strong opinion. Works either way.
This is needed because if we split pdata, we will nolonger be able to depend on the InternalRep or generated proto classes (raw, grpc). The pdatagrcp will eventually be public once we stabilize the API. The API in the pdatagrcp package is inspired from the grpc generated classes and redirects all calls to the generated classes. Some simple renames: * TraceService[Client|Server] -> Traces[Client|Server] * MetricsService[Client|Server] -> Metrics[Client|Server] * LogsService[Client|Server] -> Logs[Client|Server] Other changes: * Replace usages of grpc generated classes in otlpexporter to excercise this new package. * Left some TODOs for the moment until this package is used more to determine the right API. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
tigrannajaryan
approved these changes
May 19, 2021
Member
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
LGTM, up to you if you want to do anything about the remaining comments.
| // LogsClient is the client API for OTLP-GRPC Logs service. | ||
| // | ||
| // For semantics around ctx use and closing/ending streaming RPCs, please refer to https://godoc.org/google.golang.org/grpc#ClientConn.NewStream. | ||
| type LogsClient interface { |
Member
There was a problem hiding this comment.
Not a strong opinion. Works either way.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
* Add initial implementation of pdatagrcp This is needed because if we split pdata, we will nolonger be able to depend on the InternalRep or generated proto classes (raw, grpc). The pdatagrcp will eventually be public once we stabilize the API. The API in the pdatagrcp package is inspired from the grpc generated classes and redirects all calls to the generated classes. Some simple renames: * TraceService[Client|Server] -> Traces[Client|Server] * MetricsService[Client|Server] -> Metrics[Client|Server] * LogsService[Client|Server] -> Logs[Client|Server] Other changes: * Replace usages of grpc generated classes in otlpexporter to excercise this new package. * Left some TODOs for the moment until this package is used more to determine the right API. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Add details for the TODOs left Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed because if we split pdata, we will nolonger be able to depend on the InternalRep or generated proto classes (raw, grpc).
The pdatagrcp will eventually be public once we stabilize the API.
The API in the pdatagrcp package is inspired from the grpc generated classes and redirects all calls to the generated classes. Some simple renames:
Other changes:
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com
Updates #3104