scraperhelper: use common scraping interface#3487
Merged
bogdandrutu merged 3 commits intoopen-telemetry:mainfrom Jun 28, 2021
Merged
scraperhelper: use common scraping interface#3487bogdandrutu merged 3 commits intoopen-telemetry:mainfrom
bogdandrutu merged 3 commits intoopen-telemetry:mainfrom
Conversation
This removes the MetricsScraper and ResourceMetricsScraper interfaces in favor of a single Scraper interface that scrapes and returns pdata.Metrics. There were already helper wrappers that allow users to return MetricSlices and ResourceMetricSlices. These helpers package those results into pdata.Metrics for the base interface. Resolves #3085: This also removes the multiMetricScraper which wrapped multiple scrapers to appear as a single scraper but then functions like scraper.ID() would be empty. This was evident when trying to log errors and you couldn't figure out what scraper made the error because it was wrapped in the multiscraper.
bogdandrutu
approved these changes
Jun 28, 2021
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
Please add CHANGELOG entry
carlosalberto
approved these changes
Jun 28, 2021
bogdandrutu
reviewed
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the MetricsScraper and ResourceMetricsScraper interfaces in favor
of a single Scraper interface that scrapes and returns pdata.Metrics. There
were already helper wrappers that allow users to return MetricSlices and
ResourceMetricSlices. These helpers package those results into pdata.Metrics
for the base interface.
Resolves #3085: This also removes the multiMetricScraper which wrapped multiple
scrapers to appear as a single scraper but then functions like scraper.ID()
would be empty. This was evident when trying to log errors and you couldn't
figure out what scraper made the error because it was wrapped in the
multiscraper.