Change exporterhelper to accept ExporterCreateSettings instead of just logger#3569
Merged
bogdandrutu merged 1 commit intoopen-telemetry:mainfrom Jul 8, 2021
Merged
Conversation
…t logger In a future PR ExporterCreateSettings will carry Tracer and Meter for custom tracing/metrics. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Member
There was a problem hiding this comment.
Should we have ExporterHelperSettings instead and only pass what is needed by the helper and not entire ExporterCreateSettings? Passing ExporterCreateSettings seems to unnecessarily couple the exporter and helper stronger than necessary.
Not a strong opinion, just thinking out loud.
Member
Author
I do see this, but passing the entire |
tigrannajaryan
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a future PR ExporterCreateSettings will carry Tracer and Meter for custom tracing/metrics.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com