Use Func pattern in processorhelper, consistent with others#3570
Merged
tigrannajaryan merged 1 commit intoopen-telemetry:mainfrom Jul 13, 2021
Merged
Use Func pattern in processorhelper, consistent with others#3570tigrannajaryan merged 1 commit intoopen-telemetry:mainfrom
tigrannajaryan merged 1 commit intoopen-telemetry:mainfrom
Conversation
carlosalberto
approved these changes
Jul 6, 2021
Member
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
I wonder if the opposite change could be preferable, i.e. make all helpers use an interface instead of a func. Interface approach is more future-proof, you can extend the interface, i.e. add optional requirements and if the processor supports it the helper can use it.
Not a strong opinion but maybe worth considering.
Member
Author
|
@tigrannajaryan the interface will be implemented by users (devs of processors), so we cannot extend that as per semver. |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
processorhelperfunc
branch
from
1d76d1b to
a73b405
Compare
tigrannajaryan
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com