rename DoubleSum -> Sum#3583
Conversation
|
After looking at the PR only changes in the internal/goldendata about the pict files worries me a bit, if these can be separated and discuss more we can move forward with what we have here |
Happy to remove the changes to pict files, are there steps to regenerate them automatically documented anywhere? |
|
@codeboten I am useless here, see https://github.com/open-telemetry/opentelemetry-collector/issues/3378 where I asked the same :)) |
|
fwiw, I ran With the data in this PR and the output matched this PR. Note that there is an existing discrepancy in the data fixed in #3587 |
| cfg.MetricDescriptorType = pdata.MetricDataTypeDoubleGauge | ||
| case MetricTypeMonotonicDoubleSum: | ||
| cfg.MetricDescriptorType = pdata.MetricDataTypeDoubleSum | ||
| case MetricTypeMonotonicSum: |
There was a problem hiding this comment.
Ok my point was that I don't think we should do this change since, the Sum will have 2 possible values (Int or Double). So for this is good to keep Double in the name to signal that Sum will have Double values in the NumberDataPoint.
There was a problem hiding this comment.
Ah I see. Thanks for clarifying!
There was a problem hiding this comment.
pict changes reverted.
|
Unfortunately I cannot merge this because the upgrade of the contrib for otel-trace changes is blocked. To not waste time let's start address other issues in the meantime. One PR that we can do is to have the conversion of IntHistogram to Histogram. We need to call this code every time when we unmarshal metrics so all the components will be able to ignore IntHistograms and we can delete them. I am proposing this PR until we unblock the contrib upgrade. What do you think? |
bogdandrutu
left a comment
There was a problem hiding this comment.
LGTM but blocking because of contrib not being able to be upgraded because of otel-trace issues.
Sounds like a good next step @bogdandrutu, I've also got the PRs to rename |
Description:
Continuing the work started in updating OTLP to v0.8.0,
DoubleSumis nowSumLink to tracking Issue: Part of #3534