Skip to content

Add explicit type cast in baggage UrlDecode #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esigo merged 2 commits into from
Apr 26, 2022
Merged

Add explicit type cast in baggage UrlDecode #1353

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a7af98
Add explicit type cast in baggage UrlDecode
ThomsonTan Apr 26, 2022
3b2807a
Merge branch 'main' into FixBaggageWarning
lalitb Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion api/include/opentelemetry/baggage/baggage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@ class Baggage
};

auto from_hex = [](char c) -> char {
return std::isdigit(c) ? c - '0' : std::toupper(c) - 'A' + 10;
// c - '0' produces integer type which could trigger error/warning when casting to char,
// but the cast is safe here.
return static_cast<char>(std::isdigit(c) ? c - '0' : std::toupper(c) - 'A' + 10);
};

std::string ret;
Expand Down