Skip to content

Fix doxygen pages#4099

Open
vortex-wq wants to merge 7 commits into
open-telemetry:mainfrom
vortex-wq:fix-doxygen-pages
Open

Fix doxygen pages#4099
vortex-wq wants to merge 7 commits into
open-telemetry:mainfrom
vortex-wq:fix-doxygen-pages

Conversation

@vortex-wq
Copy link
Copy Markdown

Fixes #3913

Changes

  • Enable Doxygen HTML generation
  • Fix Doxygen output directory configuration
  • Add GitHub Actions workflow for automatic documentation publishing
  • Begin migration away from the legacy ReadTheDocs/Sphinx pipeline

The existing repository still contains legacy ReadTheDocs/Sphinx configuration (conf.py, Breathe/Exhale setup). This PR focuses on establishing the GitHub Pages publishing workflow first; additional cleanup/removal can follow based on maintainer preference.

Validation

  • Verified local Doxygen HTML generation
  • Verified generated HTML renders correctly in browser
  • Verified GitHub Actions workflow execution successfully

@vortex-wq vortex-wq requested a review from a team as a code owner May 23, 2026 13:38
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 23, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

Comment thread .github/workflows/publish-docs.yml Outdated
uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./docs/public/doxyoutput/html No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add destination_dir: docs here? Otherwise this action publishes to the root of gh-pages and may remove the existing benchmark data already stored on that branch.

Comment thread .github/workflows/publish-docs.yml Outdated
push:
branches:
- main
- fix-doxygen-pages
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this branch ?

@lalitb
Copy link
Copy Markdown
Member

lalitb commented May 23, 2026

@vortex-wq - Have you tested the generated Pages output from your fork? Since this PR does not create an upstream preview, could you share the rendered URL or an uploaded HTML artifact so we can review how the Doxygen docs look before merge?

EDIT - also check the CI failures related to the changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (ec8cd03) to head (933113f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4099      +/-   ##
==========================================
- Coverage   82.01%   82.00%   -0.01%     
==========================================
  Files         385      385              
  Lines       16030    16030              
==========================================
- Hits        13145    13143       -2     
- Misses       2885     2887       +2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vortex-wq
Copy link
Copy Markdown
Author

@vortex-wq - Have you tested the generated Pages output from your fork? Since this PR does not create an upstream preview, could you share the rendered URL or an uploaded HTML artifact so we can review how the Doxygen docs look before merge?

Yes, I have tested it on my local computer.

Rendered preview URL:
https://vortex-wq.github.io/opentelemetry-cpp/
The generated Doxygen HTML is being published correctly through GitHub Pages.
Screenshot 2026-05-24 121128

@lalitb
Copy link
Copy Markdown
Member

lalitb commented May 24, 2026

https://vortex-wq.github.io/opentelemetry-cpp/
The generated Doxygen HTML is being published correctly through GitHub Pages.

Thanks for sharing, this looks awesome . Do you know why it shows/renders older version 1.0.0.-rc2?

@vortex-wq
Copy link
Copy Markdown
Author

https://vortex-wq.github.io/opentelemetry-cpp/
The generated Doxygen HTML is being published correctly through GitHub Pages.

Thanks for sharing, this looks awesome . Do you know why it shows/renders older version 1.0.0.-rc2?

Oh, I noticed it right now, I have only converted/worked upon the older version so currently docs/public/conf.py still contains legacy Sphinx/Breathe/Exhale configuration, and the generated docs inherit the older project metadata/version values from the existing setup.

@lalitb
Copy link
Copy Markdown
Member

lalitb commented May 24, 2026

Should I work on changing it to existing version or migrating it to the most recent one?

Yes, I believe it should be the latest.

@vortex-wq - For this PR, please make the generated Pages output reflect the version of the source being published. Since this workflow publishes from main, it should use the current repo/dev version from the checked-out source, not the old hardcoded 1.0.0-rc2 value.

Separately, we @open-telemetry/cpp-maintainers should decide the longer-term versioning model for GitHub Pages. RTD gives us version-specific docs URLs today, while this workflow appears to publish only the current generated output. We should decide whether Pages is intended to host only current main docs, or whether we also want release/tag docs with stable versioned URLs in a follow-up.

@lalitb
Copy link
Copy Markdown
Member

lalitb commented May 24, 2026

Should I work on changing it to existing version or migrating it to the most recent one?

Yes, I believe it should be the latest.

@vortex-wq - For this PR, please make the generated Pages output reflect the version of the source being published. Since this workflow publishes from main, it should use the current repo/dev version from the checked-out source, not the old hardcoded 1.0.0-rc2 value.

Separately, we @open-telemetry/cpp-maintainers should decide the longer-term versioning model for GitHub Pages. RTD gives us version-specific docs URLs today, while this workflow appears to publish only the current generated output. We should decide whether Pages is intended to host only current main docs, or whether we also want release/tag docs with stable versioned URLs in a follow-up.

@vortex-wq - I updated this comment, just in case you miss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Publish the doxygen doc

2 participants