Explain the logical reasoning behind local Abseil snapshot + namespace renaming#797
Closed
maxgolov wants to merge 10 commits into
Closed
Explain the logical reasoning behind local Abseil snapshot + namespace renaming#797maxgolov wants to merge 10 commits into
maxgolov wants to merge 10 commits into
Conversation
…scribe the integration process
Fix header
Fix header
Adjust wording
Codecov Report
@@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 95.48% 93.64% -1.84%
==========================================
Files 156 190 +34
Lines 6614 8953 +2339
==========================================
+ Hits 6315 8383 +2068
- Misses 299 570 +271
|
Contributor
Author
|
We seriously have to do something about
We may need to edit the associated GitHub action to avoid triggering red marks, and only treat it as optional, always pass showing the code coverage rate changes. Maybe there's an option to configure a min threshold that trips the failure, excluding anything that is under 1%. Also, perhaps, if the list of changed files covers only Markdown or in |
2 tasks
Member
|
incorrectly closed by bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No code changes.
This PR is a supplementary doc that explains the logical reasoning / merits of the process used to create / refresh the Abseil snapshot in PR #572
Since some changes were not trivial, a separate section is added to elaborate on these changes.
Hopefully we should not employ this (semi-manual) process too often.