Support determining parent span from Context while creating new Span#969
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #969 +/- ##
==========================================
+ Coverage 95.36% 95.38% +0.03%
==========================================
Files 161 161
Lines 6780 6817 +37
==========================================
+ Hits 6465 6502 +37
Misses 315 315
|
jsuereth
approved these changes
Sep 3, 2021
Member
Author
|
build failed due to merge conflict with #966 , have resolved them now. |
ThomsonTan
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #955
Changes
This adds support for passing
Contextwrapping parentSpanobject while creating new Span.SpanContextobject is also kept in place. Also to avoid storing two different variables forContextandSpanContextinside StartSpanOptions struct, variant object is introduced within this struct.span.hrequiringcontext/context.handcontext/context.hrequiringspan.hthroughcontext/context_value.h) : this required addingspan_startoptions.handspan_metadata.h.cc @jsuereth
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes