Support environment variables for both OtlpGrpcExporter and OtlpHttpExporter#983
Merged
lalitb merged 2 commits intoSep 21, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #983 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 161 161
Lines 6817 6817
=======================================
Hits 6502 6502
Misses 315 315 |
owent
changed the title
otlp_environment.h to maintain shared codes of `OtlpGrpcExpo…OtlpGrpcExporter and OtlpHttpExporter
…rter` and `OtlpHttpExporter` 2. Add `timeout` and `metadata` options for `OtlpGrpcExporter` 3. Load environment variables `OTEL_EXPORTER_OTLP_TIMEOUT` , `OTEL_EXPORTER_OTLP_TRACES_TIMEOUT` , `OTEL_EXPORTER_OTLP_HEADERS` , `OTEL_EXPORTER_OTLP_TRACES_HEADERS` to initialize default options of `OtlpGrpcExporter` and `OtlpHttpExporter` 4. Load environment variables `OTEL_EXPORTER_OTLP_ENDPOINT` , `OTEL_EXPORTER_OTLP_TRACES_ENDPOINT` to initialize default options of `OtlpHttpExporter` Signed-off-by: owentou <owentou@tencent.com>
owent
force-pushed
the
environments_for_otlp_http_exporter
branch
from
f73cc76 to
269ff8f
Compare
lalitb
approved these changes
Sep 21, 2021
Member
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
Thanks for adding the support for env variables, along with timeout and headers.
Signed-off-by: owentou <owentou@tencent.com>
ThomsonTan
approved these changes
Sep 21, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #978
Fixes #909
Changes
otlp_environment.hto maintain shared codes ofOtlpGrpcExporterandOtlpHttpExportertimeoutandmetadataoptions forOtlpGrpcExporterOTEL_EXPORTER_OTLP_TIMEOUT,OTEL_EXPORTER_OTLP_TRACES_TIMEOUT,OTEL_EXPORTER_OTLP_HEADERS,OTEL_EXPORTER_OTLP_TRACES_HEADERSto initialize default options ofOtlpGrpcExporterandOtlpHttpExporterOTEL_EXPORTER_OTLP_ENDPOINT,OTEL_EXPORTER_OTLP_TRACES_ENDPOINTto initialize default options ofOtlpHttpExporterFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes