Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7873 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 304 304
Lines 23342 23342
=====================================
+ Hits 19086 19090 +4
+ Misses 3867 3864 -3
+ Partials 389 388 -1 🚀 New features to boost your workflow:
|
|
While I have no objection for this (it fixes the conflict issue which is a big improvement), I want to note that it also adds a dependency on an external private company (we've seen cases where external things like this dropped our access overnight). |
My assumption is because the collector repo uses We use bare-metal to run benchmarks instead. This would give us a stable result. |
|
@XSAM, bump |
Co-authored-by: Robert Pająk <pellared@hotmail.com>
pellared
left a comment
There was a problem hiding this comment.
Should we add https://codspeed.io/open-telemetry/opentelemetry-go somewhere in README.md?
Yeah, I am planning to do that once we can confirm the benchmark result is stable enough to be useful. |
Resolves #4537
This PR replaces the
github-action-benchmarkapproach with CodSpeed.CodSpeed addresses:
An example of benchmark result: https://codspeed.io/XSAM/opentelemetry-go/runs/697aa351f5662999a88a8bf3
Benchmark page for opentelemetry-go: https://codspeed.io/open-telemetry/opentelemetry-go