attribute: add BYTES type support#7948
attribute: add BYTES type support#7948NesterovYehor wants to merge 16 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7948 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 308 308
Lines 23655 23681 +26
=====================================
+ Hits 19343 19365 +22
- Misses 3930 3933 +3
- Partials 382 383 +1
🚀 New features to boost your workflow:
|
pellared
left a comment
There was a problem hiding this comment.
Overall LGTM. I left a few comments.
Please also add the benchmark results for ``BenchmarkBytes` in the PR description.
87ff3a1 to
95b2ce9
Compare
|
We would also need to comply with SDK attribute value limits https://opentelemetry.io/docs/specs/otel/common/#anyvalue
I propose to do this in a separate PR and also track it in a separate issue. The important thing is that both PRs would need to be shipped in the same release. If you want you can already start working it in a separate branch / draft PR EDIT: I created #7954 |
e155190 to
fc739fd
Compare
d7eb438 to
eda589a
Compare
|
@open-telemetry/go-approvers, PTAL. This can be now merged given the recent releases. |
MrAlias
left a comment
There was a problem hiding this comment.
Overall looks good. The hashing algorithm access needs attention though.
02b54de to
f6fff2d
Compare
MrAlias
left a comment
There was a problem hiding this comment.
Blocking base on #7948 (comment)
Investigation needs to be undertaken to storing the []byte as a string in value instead as a slice.
667233d to
321e817
Compare
Fixes #7933
Add BYTES type to https://pkg.go.dev/go.opentelemetry.io/otel/attribute