Add fields for DataDog propagator#225
Closed
ocelotl wants to merge 3 commits intoopen-telemetry:masterfrom
ocelotl:issue_224
Closed
Add fields for DataDog propagator#225ocelotl wants to merge 3 commits intoopen-telemetry:masterfrom ocelotl:issue_224
ocelotl wants to merge 3 commits intoopen-telemetry:masterfrom
ocelotl:issue_224
Conversation
This marks the test case as flaky, making it run at most 3 times. It is enough for one of this runs to pass to consider this test case passed and ran no more. If 3 consecutive runs of this test case fail, the test case will be considered failed. It has been reported that running this test case again makes it pass, usually. This approach is preferred over marking it as xfail(strict=False) because most of the times the test ends up passing after another run, so that in most of the cases we can still benefit from running this test case (since if it is actually failing because of a bug it will be reported as such after failing 3 times, making the team aware of an actual issue happening here).
ocelotl
requested review from
a team,
aabmass and
codeboten
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.