fix #4278: proxy all methods in ProxiedProducer/Consumer#4358
Open
JMGalvao wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix #4278: proxy all methods in ProxiedProducer/Consumer#4358JMGalvao wants to merge 1 commit intoopen-telemetry:mainfrom
JMGalvao wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
|
Contributor
|
Thanks for this! Please pull as I did a changelog resolve before triggering workflows. Please then could you address the lint issues with:
|
Remove Producer/Consumer inheritance from ProxiedProducer and ProxiedConsumer. Add __getattr__ to delegate undefined methods to the wrapped client, fixing segfaults on calls like list_topics() or assignment(). Add regression tests to verify delegation of undefined methods on both proxy classes.
JMGalvao
force-pushed
the
fix/proxied-delegation-4278
branch
from
2baa7b6 to
a4419bd
Compare
tammy-baylis-swi
moved this from Ready for review
to Easy to review / merge / close
in Python PR digest
tammy-baylis-swi
approved these changes
Mar 26, 2026
Contributor
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Thanks again! Maintainers will also have a look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4278
ProxiedProducerandProxiedConsumerinherited from the confluent-kafka C-extension classes (Producer/Consumer) but never calledsuper().__init__(). Any method not explicitly defined on the proxy class fell through to the base class with an uninitialized C handle, causingRuntimeError: Handle has been closed/Consumer closed.The fix removes inheritance and uses pure composition with
__getattr__to delegate all undefined method calls to the wrapped instance.Type of Change
Testing
Added two regression tests:
test_proxied_producer_delegates_undefined_methods— callslist_topics()onProxiedProducerand verifies it delegates to the underlying producertest_proxied_consumer_delegates_undefined_methods— callsassignment()onProxiedConsumerand verifies it delegates to the underlying consumerDoes This Require a Core Repo Change?
Checklist