fix(celery): coerce timelimit values to strings in span attributes#4361
Open
DrMeers wants to merge 2 commits intoopen-telemetry:mainfrom
Open
fix(celery): coerce timelimit values to strings in span attributes#4361DrMeers wants to merge 2 commits intoopen-telemetry:mainfrom
DrMeers wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
When only one of the two time limits is set (e.g. soft_time_limit=42 but no time_limit), the None replacement produced a mixed-type list ["", 42] which triggers an OTel mixed-type attribute warning. Coerce all values to strings for consistency. See open-telemetry#2022
Author
|
EasyCLA signed as per #4360 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When only one of the two Celery time limits is set (e.g.
soft_time_limit=42but notime_limit),set_attributes_from_context()replacesNonewith""but leaves the integer as-is, producing a mixed-type list["", 42]. This triggers an OTel mixed-type attribute warning.The fix coerces all values in the timelimit tuple to strings.
Fixes #2022
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: