Merged
Conversation
…entId sent on the wire (open-telemetry#908)
…try#1053) As per semantic conventions, set the `telemetry.sdk` parameters.
…OINT (open-telemetry#1064) * add support for env var: OTEL_EXPORTER_ZIPKIN_ENDPOINT * update method signature to use url
This aligns with the specification for Resources
* Zipkin exporter report instrumentation info
* dropping support for python 3.4
* updating changelogs and version to 0.13b0
…-telemetry#1124) * [Issue open-telemetry#1111] Add span status to tags for Zipkin exporter
…1149) Zipkin exporter translation was setting `otel.status_code` attribute as an integer which resulted in Otel collector rejecting the spans. This commit casts the value to a string.
Zipkin exporter truncates tag values to a maximum length of 128 characters. This commit makes this value configurable while keeping 128 as the default value.
…open-telemetry#1168) Zipkin annotation values are strings containing JSON documents. We cannot have deterministic ordering of event attributes as they may come in any order and python versions older than 3.7 don't have ordered dicts. We extract the annotations from exported spans, parse the JSON documents into Python dicts and then compare them.
…text (open-telemetry#1146) Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
1 task
codeboten
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the
exporter/opentelemetry-exporter-zipkinfrom the core repo into the contrib repo.The original code is being copied over from the Core repo here: https://github.com/open-telemetry/opentelemetry-python/tree/master/exporter/opentelemetry-exporter-zipkin
How Has This Been Tested?
CI tests will confirm it works correctly.
The only reason I didn't add tests yet (and I didn't plan to until we get all the packages we want in) is because the tests introduced here depend on other packages that will be coming (very soon hopefully!) in future PRs.
After the PRs with the packages are merged, I'll take the same approach I took in my large PR #47 where I got the tests to pass.
Checklist:
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated