Merged
Conversation
…telemetry#1028) Here is an example snippet that will not report tracing without this patch: with psycopg2.connect(...) as conn, conn.cursor() as cursor: cursor.execute("select 1;") Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
…text (open-telemetry#1146) Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
1 task
codeboten
suggested changes
Oct 23, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Just a few changes requested.
| - "16686:16686" | ||
| - "14268:14268" | ||
| - "9411:9411" | ||
| otopencensus: |
Contributor
There was a problem hiding this comment.
The otopencensus tests should remain in the core repo as the opencensus exporter will remain there.
Contributor
Author
There was a problem hiding this comment.
Sounds good! I've removed all the OpenCensus Tests.
| @@ -0,0 +1,60 @@ | |||
| # Copyright The OpenTelemetry Authors | |||
| @@ -0,0 +1,77 @@ | |||
| #!/usr/bin/env python3 | |||
Contributor
There was a problem hiding this comment.
This test should stay in the core repo as well, since this will be testing trace context propagation which is part of the API
NathanielRN
force-pushed
the
move-tests
branch
from
a91a673 to
4d26c1b
Compare
codeboten
approved these changes
Oct 23, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the
tests/opentelemetry-docker-testsfrom the core repo into the contrib repo.The original code is being copied over from the Core repo here: https://github.com/open-telemetry/opentelemetry-python/tree/master/tests/opentelemetry-docker-tests
How Has This Been Tested?
CI tests will confirm it works correctly.
The only reason I didn't add tests yet (and I didn't plan to until we get all the packages we want in) is because the tests introduced here depend on other packages that will be coming (very soon hopefully!) in future PRs.
After the PRs with the packages are merged, I'll take the same approach I took in my large PR #47 where I got the tests to pass.
Checklist:
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated