Make return value of get_correlations immutable#1024
Merged
codeboten merged 5 commits intoopen-telemetry:masterfrom Aug 27, 2020
Merged
Make return value of get_correlations immutable#1024codeboten merged 5 commits intoopen-telemetry:masterfrom
get_correlations immutable#1024codeboten merged 5 commits intoopen-telemetry:masterfrom
Conversation
lzchen
reviewed
Aug 24, 2020
lzchen
approved these changes
Aug 24, 2020
aabmass
approved these changes
Aug 27, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes return value of
get_correlationsimmutable via a proxy view of a copy of the original dict.According to the spec:
Fixes #1020
Type of change
Checklist: