Populate resource attributes as per semantic conventions

[codeboten]

As per semantic conventions , this changes sets the telemetry.sdk resource attributes.

Fixes #1033

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• ran unit tests

Checklist:

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been updated

[lzchen]

Was it established that we were not going the resource detector route? @aabmass

[codeboten]

Was it established that we were not going the resource detector route? @aabmass

That was my understanding based on the last comment here: #932 (comment)

[lzchen]

Was it established that we were not going the resource detector route? @aabmass

That was my understanding based on the last comment here: #932 (comment)

From the comment, it is not exactly clear to me what was the decision. I'm not sure "He suggested yesterday doing it right in the providers." refers to. Doing what in the providers? Instantiating Resources with defaults or instantiating a default resource provider somewhere else and populating the resources within the providers?

[codeboten]

Was it established that we were not going the resource detector route? @aabmass

That was my understanding based on the last comment here: #932 (comment)

From the comment, it is not exactly clear to me what was the decision. I'm not sure "He suggested yesterday doing it right in the providers." refers to. Doing what in the providers? Instantiating Resources with defaults or instantiating a default resource provider somewhere else and populating the resources within the providers?

Ah I see what you mean. I took it as instantiating the provider with the default resource which would contain the sdk attributes.

[aabmass]

Talked with James yesterday and he thinks this solution is fine. The semantic convention says:

The default OpenTelemetry SDK provided by the OpenTelemetry project MUST set telemetry.sdk.name to the value opentelemetry.

And I think the only way to accomplish this is adding the detection in the providers, not requiring the user to do it. The only other special case that I know of (that must be done in the provider) is this:

The SDK MUST extract information from the OTEL_RESOURCE_ATTRIBUTES environment variable and merge this, as the secondary resource, with any resource information provided by the user, i.e. the user provided resource information has higher priority.

These could be done by implementing ResouceDetector, but I take it that we don't rely on the user to merge these labels in, we do it automatically (in providers). Here's what I found for OT Java's implementation

• Resource.DEFAULT creation
• Then its use in the MeterProvider and TracerProvider

---

The other resources/semantic conventions that I know of are not worded as strongly (e.g. container). For these others, we can provide resource detector(s) for users to run, though I don't think it is required for GA?

[aabmass]

LGTM

[lzchen]

LGTM. I think #1063 would be a good followup for this.