Add support for OTEL_BSP_* environment variables#1120
Merged
codeboten merged 5 commits intoopen-telemetry:masterfrom Sep 24, 2020
Merged
Add support for OTEL_BSP_* environment variables#1120codeboten merged 5 commits intoopen-telemetry:masterfrom
codeboten merged 5 commits intoopen-telemetry:masterfrom
Conversation
ocelotl
force-pushed
the
issue_1105
branch
2 times, most recently
from
5e1fcfc to
5a21daa
Compare
codeboten
suggested changes
Sep 21, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
The change looks good, just a couple of comments. I'd like to see an update to the docs to list out available options.
lzchen
reviewed
Sep 23, 2020
| ) | ||
|
|
||
| if max_export_batch_size is None: | ||
| max_export_batch_size = Configuration().get( |
Contributor
There was a problem hiding this comment.
We should have validation to ensure less than or equal to max queue size.
Contributor
Author
There was a problem hiding this comment.
I think this is already implemented here.
codeboten
approved these changes
Sep 23, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments.
lzchen
approved these changes
Sep 23, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1105
Description
Add support for
OTEL_BSP_*environment variablesFixes #1105
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit test case.
test_batch_span_processor_environment_variablesChecklist: