Skip to content

Update sampling result names#1128

Merged
lzchen merged 4 commits intoopen-telemetry:masterfrom
ffe4:sampling-result-names
Sep 18, 2020
Merged

Update sampling result names#1128
lzchen merged 4 commits intoopen-telemetry:masterfrom
ffe4:sampling-result-names

Conversation

@ffe4
Copy link
Copy Markdown
Contributor

@ffe4 ffe4 commented Sep 17, 2020

Description

Update to #1115 since there was another renaming in the spec open-telemetry/opentelemetry-specification#956

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated

@ffe4 ffe4 requested a review from a team September 17, 2020 13:00
@ffe4 ffe4 changed the title Sampling result names Update sampling result names Sep 17, 2020
@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Sep 17, 2020
@aabmass aabmass self-assigned this Sep 17, 2020
Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit a59e268 into open-telemetry:master Sep 18, 2020
alertedsnake pushed a commit to alertedsnake/opentelemetry-python that referenced this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:required-for-ga To be resolved before GA release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants